chore: allow simple column to wrap to 2 lines #8403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had a change to make service port a special column that could wrap to two lines, but then I figured why not all simple columns? If text is too wide to fit into a column this will cause it to wrap to two lines. Longer text will still use ellipsis. (we could go to 3 or 4 lines, but allowing twice as much text seemed like a reasonable balance that doesn't affect the rest of the table layout) Having multiple service ports are the most obvious way to trigger this, but on very narrow columns something like "2 months" will be wrapped to: "2 months" instead of: "2 mo..." Fixes podman-desktop#5442. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
requested review from
axel7083,
lstocchi,
SoniaSandler and
cdrage
and removed request for
a team
cdrage
approved these changes
Aug 8, 2024
lstocchi
approved these changes
Aug 12, 2024
benoitf
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I had a change to make service port a special column that could wrap to two lines, but then I figured why not all simple columns? If text is too wide to fit into a column this will cause it to wrap to two lines. Longer text will still use ellipsis. (we could go to 3 or 4 lines, but allowing twice as much text seemed like a reasonable balance that doesn't affect the rest of the table layout)
Screenshot / video of UI
Before:
After:
What issues does this PR fix or reference?
Fixes #5442.
How to test this PR?
Having multiple service ports are the most obvious way to trigger this, but on very narrow columns something like "2 months" will be wrapped to: "2
months"
instead of:
"2 mo..."