fix(tests): not all update e2e tests were run #9362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odockal
requested review from
jeffmaury,
feloy and
SoniaSandler
and removed request for
a team
cbr7
approved these changes
Oct 14, 2024
|
if it's related to the update failure in e2e it's still ❌ |
|
@benoitf yes and no, it also makes sure to run all e2e update tests. I will make it draft for now. |
odockal
force-pushed
the
fix-update-e2e-tests
branch
2 times, most recently
from
9a67277 to
ac85ad6
Compare
odockal
changed the title
cbr7
approved these changes
Oct 14, 2024
odockal
force-pushed
the
fix-update-e2e-tests
branch
from
e896359 to
89bf5ed
Compare
Signed-off-by: Ondrej Dockal <odockal@redhat.com>
Signed-off-by: Ondrej Dockal <odockal@redhat.com>
Signed-off-by: Ondrej Dockal <odockal@redhat.com>
odockal
force-pushed
the
fix-update-e2e-tests
branch
from
89bf5ed to
3aa4396
Compare
benoitf
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update e2e tests are now run always when spec file is run. After a change in adding tag was introduced, portion of tests was omitted and did not catch electron update dependency that broke the functionality.
Screenshot / video of UI
What issues does this PR fix or reference?
#9361
How to test this PR?
build podman-desktop in version ie. 1.0.0 to initiate an update , also in production version with
ELECTRON_ENABLE_INSPECTusingpnpm compile:current --win nsis. setPODMAN_DESKTOP_BINARYto point to builtPodman Desktop.exeand runpnpm test:e2e:update:runand check that 6 tests being run. If there is a failure, some tests can be skipped, but total is 6.