Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codepress Admin Columns doesn't see Pods' table-based custom fields (meta keys) #2400

Closed
pglewis opened this issue Oct 13, 2014 · 7 comments
Closed

Comments

@pglewis
Copy link
Contributor

pglewis commented Oct 13, 2014

An older version of Codepress Admin Columns (1.4.9) appears to recognize table-based custom fields added by Pods. Integration broke somewhere.

@pglewis
Copy link
Contributor Author

pglewis commented Oct 15, 2014

https://github.com/pods-framework/pods/blob/f2c903/classes/PodsMeta.php#L413

Pods specifically intercepts the cpac-get-meta-by-type filter from CodePress Admin Columns in order to feed the plugin the list of fields in the case of table-based storage for CPTs (SELECT DISTINCT meta_key ... will not discover the fields when using table storage for the post type). This filter no longer appears in a search of the code for Admin Columns and I don't think it has been around since somewhere back in the 1.x versions.

@pglewis
Copy link
Contributor Author

pglewis commented Oct 15, 2014

An immediate closer looks shows there are a series of filter hooks for CPA 2.x just above the referenced line. A breakpoint in cpac_meta_keys_get() never gets hit for a custom post type, however. I don't think we're hooking the right thing.

@pglewis pglewis changed the title Codepress Admin Columns doesn't see Pods' table-based custom fields Codepress Admin Columns doesn't see Pods' table-based custom fields (meta keys) Oct 15, 2014
pglewis added a commit that referenced this issue Oct 15, 2014
@sc0ttkclark sc0ttkclark modified the milestone: Pods 3.0 Oct 27, 2014
@sc0ttkclark sc0ttkclark self-assigned this Oct 27, 2014
@realdadfish
Copy link

I'm still on Pods 2.5 and while this bug is still open (and the milestone is set to 3.0) the above patch ebecfba seem to have made it already into this very version of the Pods framework - at least I can see it in my installation.

I'm reporting this obviously because custom fields are (again?) not visible even with this change. I am using codepress' admin columns 2.3.2.

@Shelob9
Copy link
Contributor

Shelob9 commented Jan 8, 2015

@tommyd3mdi Thanks for the report. I am putting this back into 2.X for more research.

@Shelob9 Shelob9 modified the milestones: Pods 2.5.3, Pods 2.5.2 Mar 2, 2015
@pglewis pglewis added Status: Need User Feedback Waiting on feedback from user who reported issue and removed Bug: Regression Status: Researched labels May 30, 2015
@pglewis
Copy link
Contributor Author

pglewis commented May 30, 2015

This is "can't reproduce" for me at the moment. The user interface is not 100% intuitive for custom fields, but the following works for me in testing with both table and meta based storage on a custom post type:

  • Click "Add Column"
  • For "Type", choose "Custom Field" in the "Custom" section

Selecting "Custom Field" will modify the UI and provide a new drop down for the actual custom fields.

I'm going to punt this from 2.5.3 for now, let me know if this is still an issue and if there is something different I need to do to reproduce the problem.

@pglewis pglewis modified the milestones: Pods 2.5.4, Pods 2.5.3 May 30, 2015
@pglewis pglewis assigned pglewis and unassigned sc0ttkclark May 30, 2015
@Ramoonus
Copy link
Contributor

@markoheijnen

@sc0ttkclark sc0ttkclark modified the milestones: Pods 2.5.4, Pods 3.0 Jun 12, 2015
@sc0ttkclark sc0ttkclark modified the milestones: Pods 3.0, Pods 2.5.4 Jun 12, 2015
@pglewis
Copy link
Contributor Author

pglewis commented Dec 28, 2015

Closing this since we've not been able to get any information to reproduce it.

@pglewis pglewis closed this as completed Dec 28, 2015
@sc0ttkclark sc0ttkclark removed the Status: Need User Feedback Waiting on feedback from user who reported issue label Dec 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants