Allow fields to be sorted by orderby … #2350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two separate but connected issues. First if orderby is passed then the $data array is never populated. Then looping through $ids will always give it results sorted by priority in the relationships field (data returned by lookup_related_items) Fixes pods-framework#2277
|
I'm also not sure why $items isn't just returned or copied over, but with some of the weird complexity in pods there might be a reason. |
|
@sc0ttkclark Do you find any of the concerns he raises to be valid? If this works (I will test) I think this and a few other little things could be worth a very small point release. People want what this fixes all the time in forums and the work around that I recommend sucks. |
|
When I checkout this branch I get |
Shelob9
added a commit
that referenced
this pull request
Sep 23, 2014
Allow fields to be sorted by orderby & fix #2277
|
Sounds good |
jamesgol
added a commit
to jamesgol/pods
that referenced
this pull request
Sep 27, 2014
3.0-unstable version of pods-framework#2350
jamesgol
added a commit
that referenced
this pull request
Jan 3, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two separate but connected issues. First if orderby is passed then the $data array is
never populated. Then looping through $ids will always give it results sorted by priority
in the relationships field (data returned by lookup_related_items)
Fixes #2277