Don't assume wp_ is the prefix

[jamesgol]

Fixes #2306

I did some grepping around and didn't really see any other cases like this

[sc0ttkclark]

Was this from encountering a problem? WP itself uses wp_[0-9]*_capabilities for it's capabilities serialized array for user meta. I once had it using $wpdb for prefixing, but it was reported broken and we found that to be the cause. We should just double check inside WP core what it does, if it's using prefix properly there.

[pglewis]

@sc0ttkclark: Issue #2306 was referenced here

[sc0ttkclark]

Do we need $wpdb->base_prefix here then?

[jamesgol]

After doing the 2.x fix I saw in 3.0 that it was using $wpdb->base_prefix. When I looked at the value in xdebug they contained the same setup on my test. I couldn't really find a definitive answer on when to use base_prefix vs prefix.

http://codex.wordpress.org/Writing_a_Plugin
says to use $wpdb->prefix

[sc0ttkclark]

Needs to be base_prefix in our usage here, it is certainly confusing.