Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

composer: switch to phpunit 4.6 #2783

Closed
wants to merge 2 commits into from
Closed

composer: switch to phpunit 4.6 #2783

wants to merge 2 commits into from

Conversation

Ramoonus
Copy link
Contributor

@Ramoonus Ramoonus commented Mar 6, 2015

current version of phpunit is 4.5.2

@sc0ttkclark sc0ttkclark self-assigned this Mar 6, 2015
@sc0ttkclark sc0ttkclark modified the milestones: Pods 2.5.3, Pods 3.0 Mar 6, 2015
@sc0ttkclark sc0ttkclark added Patch Type: Enhancement Enhancements to features that already exist, but are not major additions labels Mar 6, 2015
@Ramoonus
Copy link
Contributor Author

Ramoonus commented Mar 6, 2015

https://github.com/sebastianbergmann/phpunit/blob/master/ChangeLog-4.4.md

https://github.com/sebastianbergmann/phpunit/blob/master/ChangeLog-4.5.md

@Ramoonus
Copy link
Contributor Author

Ramoonus commented Mar 7, 2015

strangely WordPress 3.9-4.1 and HHVM builds work

@Ramoonus
Copy link
Contributor Author

Ramoonus commented Mar 7, 2015

maybe this should be tested with the 2.x branch instead
the build fails mostly on Pods 3 stuff, not PHPUnit things

@Ramoonus
Copy link
Contributor Author

can be upped to 4.6.0 right now

@Ramoonus Ramoonus changed the title composer: switch to phpunit 4.5 composer: switch to phpunit 4.6 May 24, 2015
@Ramoonus
Copy link
Contributor Author

i think it`s now ready

https://github.com/sebastianbergmann/phpunit/blob/master/ChangeLog-4.6.md

@sc0ttkclark
Copy link
Member

Can you refresh your branch and push? Will merge

@sc0ttkclark sc0ttkclark added the Status: Need User Feedback Waiting on feedback from user who reported issue label May 29, 2015
@sc0ttkclark sc0ttkclark modified the milestones: Pods 3.0, Pods 3.1 May 29, 2015
@Ramoonus
Copy link
Contributor Author

you want this on?;
2.x
release/3.0

@Ramoonus Ramoonus closed this May 29, 2015
@Ramoonus Ramoonus mentioned this pull request May 29, 2015
Merged
@sc0ttkclark sc0ttkclark modified the milestones: Pods 3.0, Pods 3.1 May 29, 2015
@sc0ttkclark sc0ttkclark removed Needs Testing Status: Need User Feedback Waiting on feedback from user who reported issue labels May 29, 2015
@sc0ttkclark
Copy link
Member

Both yeah

@sc0ttkclark sc0ttkclark removed the Type: Enhancement Enhancements to features that already exist, but are not major additions label May 29, 2015
@Ramoonus
Copy link
Contributor Author

done:
#2987
#2988

@Ramoonus Ramoonus reopened this May 29, 2015
@PodsBot PodsBot mentioned this pull request Jun 11, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sc0ttkclark sc0ttkclark

Labels
None yet
Projects
None yet
Milestone
Pods 3.x - Holding
Development

Successfully merging this pull request may close these issues.
2 participants
@Ramoonus @sc0ttkclark