Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #3000 Update post filed in pod instance before saving (3.0) #3002

Merged
merged 4 commits into from
Jun 2, 2015

Conversation

tuanmh
Copy link
Contributor

@tuanmh tuanmh commented Jun 1, 2015

No description provided.

@@ -3040,6 +3040,21 @@ public function update_meta( $object_type, $_null = null, $object_id = 0, $meta_

$pod = self::$current_field_pod;

if ( ( isset( $pod->fields[ $meta_key ] ) || false !== strpos( $meta_key, '.' ) ) && $pod->row !== null) {

$key = $meta_key;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be sure to use tabs instead of spaces for consistency with the codebase.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh, probably something wrong with sublime, let me update it :)

@sc0ttkclark sc0ttkclark added this to the Pods 3.0 milestone Jun 1, 2015
@sc0ttkclark sc0ttkclark self-assigned this Jun 1, 2015
@sc0ttkclark
Copy link
Member

Related: #3000
2.x patch: #3001

@tuanmh
Copy link
Contributor Author

tuanmh commented Jun 1, 2015

@sc0ttkclark any ideas for the test failure? 😨 I will also figure out myself :)

@sc0ttkclark
Copy link
Member

3.0 tests don't pass right now, that's expected, we're actively tweaking some things because 3.0 is still unstable at the moment.

@sc0ttkclark sc0ttkclark assigned pglewis and sc0ttkclark and unassigned sc0ttkclark and pglewis Jun 2, 2015
sc0ttkclark added a commit that referenced this pull request Jun 2, 2015
Fixed #3000 Update post filed in pod instance before saving (3.0)
@sc0ttkclark sc0ttkclark merged commit 60e7377 into pods-framework:release/3.0 Jun 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants