Allow pod_exists() to work if passed a post_type name #3990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_posts() returns an array with the results even if you are only asking for 1 post per page.
jimtrue
added
the
Status: In Progress
|
For some additional context. If you would call is_pod( $post ); on a WordPress post object (that was actually a post_type of a Pod) it would return false. |
sc0ttkclark
requested changes
Mar 2, 2017
classes/PodsAPI.php
Outdated
| @@ -5324,6 +5324,9 @@ public function pod_exists ( $params, $type = null ) { | |||
| 'post_type' => '_pods_pod', | |||
| 'posts_per_page' => 1 | |||
| ) ); | |||
| if ( is_array( $pod ) ) { | |||
There was a problem hiding this comment.
I'd prefer that there are blank lines between conditional block sets.
sc0ttkclark
approved these changes
Mar 2, 2017
sc0ttkclark
removed
the
Status: In Progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_posts() returns an array with the results even if you are only asking for 1 post per page.