Pods 3.2.8

.github/workflows/tests-php.yml

@@ -122,7 +122,7 @@ jobs:
       # Upload artifacts (On failure)
       # ------------------------------------------------------------------------------
       - name: Upload artifacts
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         if: failure()
         with:
           name: output ${{ matrix.suite }}

.phpcs.xml

@@ -16,7 +16,7 @@
 	<arg name="colors"/>
 	<arg name="report" value="full,summary"/>
 
-	<rule ref="TribalScents"/>
+	<rule ref="StellarWP"/>
 	<rule ref="WordPress-VIP-Go"/>
 	<rule ref="WordPress">
 		<exclude name="WordPress.Files.FileName"/>

changelog.txt

@@ -2,6 +2,27 @@ Found a bug? Have a great feature idea? Get on GitHub and tell us about it and w
 
 Our GitHub has the full list of all prior releases of Pods: https://github.com/pods-framework/pods/releases
 
+= 3.2.8 - November 17th, 2024 =
+
+REMINDER: PHP support for Pod Templates and Pod Pages been turned off by default in Pods 3.2.7+ (`PODS_DISABLE_EVAL` constant set to `false` can be used to re-enable it). It will be completely removed in Pods 3.3 after being deprecated back in Pods 2.3. (@sc0ttkclark)
+
+* Feature: Migrate the PHP in your Pod Templates and Pod Pages directly into your current theme with a new Pods Admin > Tools > Migrate PHP tool. We recommend you use a child theme that you control. PHP warnings now appear on the Pod Template and Pod Page editor screens to prompt you to run the migration. (@sc0ttkclark)
+* Feature: Updated the design and user experience of the various guided screens inside of the Pods Admin to make it easier to read and click through on small screens. (@sc0ttkclark, @heybran)
+* Enhanced: Pod Page template part handling for PHP template files now passes the `$pods` variable. (@sc0ttkclark)
+* Enhanced: Added support for parsing magic tags in Pod Template files in the theme when you set the PHP header comment `Magic Tags: Enabled`. (@sc0ttkclark)
+* Enhanced: Run wpautop on Pods Item List and Pods Related Item List blocks for the "not found" content if they are not already formatted. (@sc0ttkclark)  
+* Fixed: Only running wpautop for block the Pods Field block content if it does not contain div, ul, ol, heading, or p HTML tags. (@sc0ttkclark)  
+* Fixed: Resolve issue with empty strings showing when using magic tags before/after functionality. (@JoryHogeveen)
+* Fixed: Ignore more internal WP post types and taxonomies plus others from other plugins.
+* Fixed: Move load_plugin_textdomain usage into init and make it optional with the constant `PODS_LOAD_TEXTDOMAIN` set to `true`. It is no longer needed for WordPress.org plugins but may be needed in the future for testing. (@sc0ttkclark)
+* Fixed: When getting plugin data, don't make it translatable. (@sc0ttkclark)
+* Fixed: When saving bidirectional relationship, attempt to save hook up existing related items data in the `wp_podsrel` table with the bidirectional connection. (@sc0ttkclark)
+* Fixed: Resolve PHP notices with site debug information. (@sc0ttkclark)
+* Fixed: Resolve PHP warnings with empty template code. (@sc0ttkclark)
+* Fixed: More improvements to Pod Page and Pod Template file loading from themes. (@sc0ttkclark)
+* Fixed: Resolve issue with slug fields not formatting as expected. (@sc0ttkclark)
+* Fixed: SCSS migrated from `@import` to `@use` for compatibility with the latest versions of our SCSS scripting. (@sc0ttkclark)
+
 = 3.2.7.1 - October 9th, 2024 =
 
 * Security: Lock down heading field to only specific allowed HTML tags and preventing it from being used to insert malicious scripts. Props to the CleanTalk / Dmitrii Ignatyev for responsibly reporting this. (@sc0ttkclark)

classes/Pods.php

@@ -4329,7 +4329,7 @@ private function process_magic_tags( $tag ) {
 			) );
 		}
 
-		if ( null !== $value && false !== $value ) {
+		if ( $value || is_numeric( $value ) ) {
 			return $before . $value . $after;
 		}
 

classes/PodsAPI.php

@@ -4017,7 +4017,9 @@ public function save_field( $params, $table_operation = true, $sanitized = false
 
 					pods_query( '
 						UPDATE `@wp_podsrel`
-						SET `related_field_id` = 0
+						SET
+							`related_pod_id` = 0,
+							`related_field_id` = 0
 						WHERE `field_id` = %d
 					', array(
 						$old_sister_id,
@@ -4028,14 +4030,33 @@ public function save_field( $params, $table_operation = true, $sanitized = false
 			update_post_meta( $sister_id, 'sister_id', $params->id );
 
 			if ( true === $db && pods_podsrel_enabled( $field, 'save' ) ) {
-				pods_query( '
-					UPDATE `@wp_podsrel`
-					SET `related_field_id` = %d
-					WHERE `field_id` = %d
-				', array(
-					$params->id,
-					$sister_id,
-				) );
+				$sister_field = $this->load_field( [ 'id' => $sister_id ] );
+
+				if ( $sister_field ) {
+					pods_query( '
+						UPDATE `@wp_podsrel`
+						SET
+							`related_pod_id` = %d,
+							`related_field_id` = %d
+						WHERE `field_id` = %d
+					', [
+						$pod['id'],
+						$params->id,
+						$sister_id,
+					] );
+
+					pods_query( '
+						UPDATE `@wp_podsrel`
+						SET
+							`related_pod_id` = %d,
+							`related_field_id` = %d
+						WHERE `field_id` = %d
+					', [
+						$sister_field->get_parent_id(),
+						$sister_id,
+						$params->id,
+					] );
+				}
 			}
 		} elseif ( 0 < $old_sister_id ) {
 			delete_post_meta( $old_sister_id, 'sister_id' );

classes/PodsAdmin.php

@@ -4817,7 +4817,16 @@ public function add_debug_information( $info ) {
 					$value = $setting_field['site_health_data'][ $value ];
 				} elseif ( $has_value && isset( $setting_field['data'] ) && isset( $setting_field['data'][ $value ] ) ) {
 					$value = $setting_field['data'][ $value ];
-				} elseif ( 'boolean' === $setting_field['data'] || '1' === $value || '0' === $value ) {
+				} elseif (
+					(
+						isset( $setting_field['data'] )
+						&& 'boolean' === $setting_field['data']
+					)
+					&& (
+						'1' === $value
+						|| '0' === $value
+					)
+				) {
 					$value = '1' === $value ? __( 'Yes', 'pods' ) : __( 'No', 'pods' );
 				}
 			}

classes/PodsInit.php

@@ -260,10 +260,6 @@
 			define( 'PODS_DISABLE_EVAL', true );
 		}
 
-		if ( ! defined( 'PODS_TEXTDOMAIN' ) || PODS_TEXTDOMAIN ) {
-			load_plugin_textdomain( 'pods' );
-		}
-
 		if ( ! defined( 'PODS_STATS_TRACKING' ) || PODS_STATS_TRACKING ) {
 			$this->stats_tracking( PODS_FILE, 'pods' );
 		}
@@ -566,6 +562,10 @@
 		if ( method_exists( $avatar, 'get_avatar_data' ) ) {
 			add_filter( 'get_avatar_data', array( $avatar, 'get_avatar_data' ), 10, 2 );
 		}
+
+		if ( defined( 'PODS_TEXTDOMAIN' ) && PODS_TEXTDOMAIN ) {
+			load_plugin_textdomain( 'pods' );
+		}
 	}
 
 	/**
@@ -2424,9 +2424,9 @@
 		pods_container_register_service_provider( \Pods\Service_Provider::class );
 		pods_container_register_service_provider( \Pods\Admin\Service_Provider::class );
 		pods_container_register_service_provider( \Pods\Blocks\Service_Provider::class );
 		pods_container_register_service_provider( \Pods\Integrations\Service_Provider::class );
 		pods_container_register_service_provider( \Pods\REST\V1\Service_Provider::class );
 		pods_container_register_service_provider( \Pods\Integrations\WPGraphQL\Service_Provider::class );
 
 		// Add WP-CLI commands.
 		if ( defined( 'WP_CLI' ) && WP_CLI ) {

classes/PodsMeta.php

@@ -2949,6 +2949,16 @@ public function is_type_covered( $type, $object_name = null ) {
 				'wp_navigation'        => true,
 				'wp_template'          => true,
 				'wp_template_part'     => true,
+				'wp_font_face'         => true,
+				'wp_font_family'       => true,
+				// Disable ACF post types.
+				'acf-taxonomy'         => true,
+				'acf-post-type'        => true,
+				'acf-field-group'      => true,
+				'acf-field'            => true,
+				// Disable Advanced views.
+				'acf_views'            => true,
+				'acf_cards'            => true,
 				// Disable Beaver Builder post types.
 				'fl-theme-layout'      => true,
 				'fl-builder-template'  => true,
@@ -2973,6 +2983,7 @@ public function is_type_covered( $type, $object_name = null ) {
 				'post_format'                  => true,
 				'wp_theme'                     => true,
 				'wp_template_part_area'        => true,
+				'wp_pattern_category'          => true,
 				// Disable Beaver Builder taxonomies.
 				'fl-builder-template-category' => true,
 				'fl-builder-template-type'     => true,

components/Migrate-ACF/ui/wizard.php

@@ -9,57 +9,67 @@
 			<?php echo PodsForm::field( '_wpnonce', wp_create_nonce( 'pods-component-' . $component . '-' . $method ), 'hidden' ); ?>
 			<?php echo PodsForm::field( 'cleanup', 0, 'hidden', array( 'attributes' => array( 'id' => 'pods_cleanup' ) ) ); ?>
 
-			<h2 class="italicized"><?php _e( 'Migrate: Import from Advanced Custom Fields', 'pods' ); ?></h2>
+			<h2 class="italicized"><?php esc_html_e( 'Migrate: Import from Advanced Custom Fields', 'pods' ); ?></h2>
 
 			<img src="<?php echo esc_url( PODS_URL ); ?>ui/images/pods-logo-notext-rgb-transparent.png" class="pods-leaf-watermark-right" />
 
 			<div id="pods-wizard-box" class="pods-wizard-steps-2 pods-wizard-hide-first">
 				<div id="pods-wizard-heading">
 					<ul>
 						<li class="pods-wizard-menu-current" data-step="1">
-							<i></i> <span>1</span> <?php _e( 'Setup', 'pods' ); ?>
+							<i></i> <span>1</span> <?php esc_html_e( 'Step 1: Setup', 'pods' ); ?>
 							<em></em>
 						</li>
 						<li data-step="2">
-							<i></i> <span>2</span> <?php _e( 'Migrate', 'pods' ); ?>
+							<i></i> <span>2</span> <?php esc_html_e( 'Step 2: Migrate', 'pods' ); ?>
 							<em></em>
 						</li>
 					</ul>
 				</div>
 				<div id="pods-wizard-main">
 					<div id="pods-wizard-panel-1" class="pods-wizard-panel">
 						<div class="pods-wizard-content">
-							<p><?php _e( 'Advanced Custom Fields provides an interface to create Custom Post Types and Custom Taxonomies. You can import these and their settings directly into Pods', 'pods' ); ?></p>
+							<p><?php esc_html_e( 'Advanced Custom Fields provides an interface to create Custom Post Types and Custom Taxonomies. You can import these and their settings directly into Pods', 'pods' ); ?></p>
 						</div>
-						<div id="pods-wizard-options">
-							<div class="pods-wizard-option">
-								<a href="#pods-wizard-import" data-opt="0">
-									<h2><?php _e( 'Import Only', 'pods' ); ?></h2>
-
-									<p><?php _e( 'This will import your Custom Post Types and Taxonomies.', 'pods' ); ?></p>
-									<p><?php _e( 'Until you remove them from Advanced Custom Fields, these will be treated by Pods as extended content types.', 'pods' ); ?></p>
-								</a>
-
-								<p><br /></p>
-							</div>
-							<div class="pods-wizard-option">
-								<a href="#pods-wizard-import-clean" data-opt="1">
-									<h2><?php _e( 'Import and Clean Up', 'pods' ); ?></h2>
-
-									<p><?php _e( 'This will import your Custom Post Types and Taxonomies, and then remove them from Advanced Custom Fields.', 'pods' ); ?></p>
-								</a>
 
-								<p><br /></p>
+						<div id="pods-wizard-options">
+							<div class="pods-wizard-options-list">
+								<div class="pods-wizard-option">
+									<a href="#pods-wizard-import" data-opt="0">
+										<div>
+											<h2><?php esc_html_e( 'Import Only', 'pods' ); ?></h2>
+
+											<p><?php esc_html_e( 'This will import your Custom Post Types and Taxonomies.', 'pods' ); ?></p>
+											<p><?php esc_html_e( 'Until you remove them from Advanced Custom Fields, these will be treated by Pods as extended content types.', 'pods' ); ?></p>
+										</div>
+										<span>&#10095;</span>
+									</a>
+								</div>
+								<div class="pods-wizard-option">
+									<a href="#pods-wizard-import-clean" data-opt="1">
+										<div>
+											<h2><?php esc_html_e( 'Import and Clean Up', 'pods' ); ?></h2>
+
+											<p><?php esc_html_e( 'This will import your Custom Post Types and Taxonomies, and then remove them from Advanced Custom Fields.', 'pods' ); ?></p>
+										</div>
+										<span>&#10095;</span>
+									</a>
+								</div>
 							</div>
 						</div>
 					</div>
-					<div id="pods-wizard-panel-2" class="pods-wizard-panel">
+					<div id="pods-wizard-panel-2" class="pods-wizard-panel pods-wizard-option-content">
 						<div class="pods-wizard-content">
-							<p><?php _e( 'Choose below which Custom Post Types and Taxonomies you want to import into Pods', 'pods' ); ?></p>
+							<p><?php esc_html_e( 'Choose below which Custom Post Types and Taxonomies you want to import into Pods', 'pods' ); ?></p>
+
+							<p>
+								<a href="#toggle" class="button pods-wizard-toggle-all"
+									data-toggle="all"><?php esc_html_e( 'Toggle everything on / off', 'pods' ); ?></a>
+							</p>
 						</div>
 
 						<div class="stuffbox">
-							<h3><label for="link_name"><?php _e( 'Choose Post Types to Import', 'pods' ); ?></label>
+							<h3><label for="link_name"><?php esc_html_e( 'Choose Post Types to Import', 'pods' ); ?></label>
 							</h3>
 
 							<div class="inside pods-manage-field pods-dependency">
@@ -68,10 +78,15 @@
 									?>
 									<div class="pods-field-option-group">
 										<p class="pods-field-option-group-label">
-											<?php _e( 'Available Post Types', 'pods' ); ?>
+											<?php esc_html_e( 'Available Post Types', 'pods' ); ?>
 										</p>
 
 										<div class="pods-pick-values pods-pick-checkbox">
+											<p>
+												<a href="#toggle" class="button pods-wizard-toggle-all"
+													data-toggle="post_type"><?php esc_html_e( 'Toggle all on / off', 'pods' ); ?></a>
+											</p>
+
 											<ul>
 												<?php
 												foreach ( $post_types as $post_type ) {
@@ -97,15 +112,15 @@
 									<?php
 								} else {
 									?>
-									<p class="padded"><?php _e( 'No Post Types were found.', 'pods' ); ?></p>
+									<p class="padded"><?php esc_html_e( 'No Post Types were found.', 'pods' ); ?></p>
 									<?php
 								}//end if
 								?>
 							</div>
 						</div>
 
 						<div class="stuffbox">
-							<h3><label for="link_name"><?php _e( 'Choose Taxonomies to Import', 'pods' ); ?></label>
+							<h3><label for="link_name"><?php esc_html_e( 'Choose Taxonomies to Import', 'pods' ); ?></label>
 							</h3>
 
 							<div class="inside pods-manage-field pods-dependency">
@@ -114,10 +129,15 @@
 									?>
 									<div class="pods-field-option-group">
 										<p class="pods-field-option-group-label">
-											<?php _e( 'Available Taxonomies', 'pods' ); ?>
+											<?php esc_html_e( 'Available Taxonomies', 'pods' ); ?>
 										</p>
 
 										<div class="pods-pick-values pods-pick-checkbox">
+											<p>
+												<a href="#toggle" class="button pods-wizard-toggle-all"
+													data-toggle="taxonomy"><?php esc_html_e( 'Toggle all on / off', 'pods' ); ?></a>
+											</p>
+
 											<ul>
 												<?php
 												foreach ( $taxonomies as $taxonomy ) {
@@ -141,7 +161,7 @@
 									<?php
 								} else {
 									?>
-									<p class="padded"><?php _e( 'No Taxonomies were found.', 'pods' ); ?></p>
+									<p class="padded"><?php esc_html_e( 'No Taxonomies were found.', 'pods' ); ?></p>
 									<?php
 								}//end if
 								?>
@@ -151,8 +171,8 @@
 
 					<div id="pods-wizard-actions" class="pods-wizard-button-interface">
 						<div id="pods-wizard-toolbar">
-							<button id="pods-wizard-start" class="button button-secondary"><?php _e( 'Start Over', 'pods' ); ?></button>
-							<button id="pods-wizard-next" class="button button-primary" data-next="<?php esc_attr_e( 'Next Step', 'pods' ); ?>" data-finished="<?php esc_attr_e( 'Finished', 'pods' ); ?>" data-processing="<?php esc_attr_e( 'Processing', 'pods' ); ?>.."><?php _e( 'Next Step', 'pods' ); ?></button>
+							<button id="pods-wizard-start" class="button button-secondary"><?php esc_html_e( 'Start Over', 'pods' ); ?></button>
+							<button id="pods-wizard-next" class="button button-primary" data-next="<?php esc_attr_e( 'Next Step', 'pods' ); ?>" data-finished="<?php esc_attr_e( 'Finished', 'pods' ); ?>" data-processing="<?php esc_attr_e( 'Processing', 'pods' ); ?>.."><?php esc_html_e( 'Next Step', 'pods' ); ?></button>
 						</div>
 						<div id="pods-wizard-finished">
 
@@ -173,7 +193,33 @@
 		jQuery( '#pods_cleanup' ).val( $opt.data( 'opt' ) );
 	};
 
+	const toggle_all = {
+		all: true
+	};
+
 	jQuery( function ( $ ) {
+		$( '.pods-wizard-toggle-all' ).on( 'click', function ( e ) {
+			e.preventDefault();
+
+			const toggleData = $( this ).data( 'toggle' );
+
+			if ( 'undefined' == typeof toggle_all[toggleData] ) {
+				toggle_all[toggleData] = true;
+			}
+
+			let $parent;
+
+			if ( 'all' !== toggleData ) {
+				$parent = $( this ).closest( '.pods-field-option-group' );
+			} else {
+				$parent = $( this ).closest( '.pods-wizard-option-content' );
+			}
+
+			$parent.find( '.pods-field.pods-boolean input[type="checkbox"]' ).prop( 'checked', (!toggle_all[toggleData]) );
+
+			toggle_all[toggleData] = (!toggle_all[toggleData]);
+		} );
+
 		$( document ).Pods( 'validate' );
 		$( document ).Pods( 'submit' );
 		$( document ).Pods( 'wizard' );