Replace SystemTime with Instant
#187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jssblck
commented
Jan 29, 2022
Comment on lines
55
to
59
| tracing::info!( | ||
| status = %resp.status(), | ||
| "response" | ||
| error = %err, | ||
| duration = ?duration, | ||
| "error" | ||
| ); |
There was a problem hiding this comment.
This is also a slight change in functionality- I personally thought it'd be useful to see the duration of failed requests too, but totally fine to change this back if you'd prefer.
|
I agree! Using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! Thanks for making such a great library!
I recently got started with Poem and needed to customize the default
Tracingmiddleware, so I looked at its implementation and noticed it was usingSystemTime.I thought switching to
Instantwould make the code a bit simpler while preserving the intent, but happy to close if you disagree. Thanks!