Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: trace nested route with original uri #371

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Fix: trace nested route with original uri #371

merged 1 commit into from
Aug 18, 2022

Conversation

brunobell
Copy link
Contributor

As described in title. @sunli829 thanks for you hard work! ❤️

@brunobell
Copy link
Contributor Author

I nested router /index on /api, now it's tracing as expected as shown below:

2022-08-18T09:44:04.158639Z  INFO request{remote_addr=socket://127.0.0.1:5647 version=HTTP/1.0 method=GET path=/v1/index}: poem::middleware::tracing_mw: response status=200 OK duration=33.8µs

@brunobell brunobell force-pushed the bugfix-trace-nested-route-with-original-uri branch from 8d9b431 to 234a8a3 Compare August 18, 2022 09:50
@sunli829 sunli829 merged commit 61723e7 into poem-web:master Aug 18, 2022
@sunli829
Copy link
Collaborator

Thanks!

@brunobell brunobell deleted the bugfix-trace-nested-route-with-original-uri branch August 18, 2022 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brunobell @sunli829