Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public path pattern #522

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Public path pattern #522

merged 2 commits into from
Mar 10, 2023

Conversation

tkubicz
Copy link
Contributor

@tkubicz tkubicz commented Mar 3, 2023

Right now PathPattern struct is not accessible. This PR makes it reachable.

Private PathPattern prevents users from writing their middleware that wants to rely on path patterns. Currently existing OpenTelemetryMetrics middleware is really a no-go for some, because of the enormous cardinality (HTTP_URL is to blame).

@sunli829 sunli829 merged commit 46a482c into poem-web:master Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants