fix: alive connections counter for graceful shutdown #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DDtKey
commented
Mar 7, 2023
poem/src/server.rs
Outdated
| @@ -135,9 +135,8 @@ where | |||
| let notify = notify.clone(); | |||
| let timeout_notify = timeout_notify.clone(); | |||
|
|
|||
| alive_connections.fetch_add(1, Ordering::SeqCst); | |||
There was a problem hiding this comment.
Btw, I see SeqCst is used here and it's strict.
Probably it should be refactored to Acquire/Release 🤔
There was a problem hiding this comment.
Could you help me with this? 🙂
DDtKey
force-pushed
the
fix-connection-counting
branch
from
64ff07c to
c58770b
Compare
DDtKey
force-pushed
the
fix-connection-counting
branch
from
1e43bc3 to
7abaa10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's currently looks a bit fragile:
It's possible to spawn new future, but parallel task will finish before spawned task is polled.
So this check will notify waiter & stop server:
It's hard to test, however sometimes we're encountering
connection reseterrors on client end, while server side almost immediately logged correct graceful shutdown & server stopped (we use large enough timeout, so it's not the case)I believe it's more reliable & safe to increase counter before spawning the task of serving.