Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember 1.13.0 Deprecations #161

Closed
devotox opened this issue Jul 13, 2015 · 9 comments
Closed

Ember 1.13.0 Deprecations #161

devotox opened this issue Jul 13, 2015 · 9 comments

Comments

@devotox
Copy link

devotox commented Jul 13, 2015

cdv-generic-nav-bar just needs to use the new HTMLBars style like below

{{#if nav.leftButton.text}}
  <button {{action 'leftButton'}}>
    {{#if nav.leftButton.icon}}
      <i class="icon {{nav.leftButton.icon}}"></i>
    {{/if}}
    {{nav.leftButton.text}}
  </button>
{{/if}}

{{#if nav.title.text}}
  <h1>
    {{nav.title.text}}
  </h1>
{{/if}}

{{#if nav.rightButton.text}}
  <button {{action 'rightButton'}}>
    {{#if nav.rightButton.icon}}
      <i class="icon {{nav.rightButton.icon}}"></i>
    {{/if}}
    {{nav.rightButton.text}}
  </button>
{{/if}}
@kitsunde
Copy link

kitsunde commented Aug 4, 2015

Both #150 and #148 is trying to fix this but neither has been merged.

@timbaas
Copy link

timbaas commented Oct 21, 2015

+1

1 similar comment
@vsymguysung
Copy link

+1

@Dragsbaek
Copy link

Any reasons this haven't been merged yet?

@shaunc
Copy link

shaunc commented Jan 9, 2016

Is this project still active? The underlying projects (ember, cordova) have been moving forward, but not much progress here. Is there a suggested alternative if this isn't active?

@runspired
Copy link
Contributor

@shaunc I'm working on a replacement project that focuses on more than just cordova, join #mobile on the ember slack or #ember-cli-platforms

@shaunc
Copy link

shaunc commented Jan 9, 2016

@runspired -- Thanks for the info on #mobile ... (for the record: https://embercommunity.slack.com/archives/mobile/p1452369014001399)

@MatthewHager
Copy link

Anyone available/open to help maintain the repo? If so, let me know and I'll give you access.

@BryanH
Copy link
Contributor

BryanH commented Jan 19, 2016

Merged.

@BryanH BryanH closed this as completed Jan 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants