Update cdv-generic-nav-bar.hbs for new Ember style #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@OpakAlex Thanks, but how about adapting https://github.com/poetic/ember-cli-cordova/blob/master/tests/integration/nav-bar-test.js ? I think this should be included in the PR. |
|
i think my PR can be close, and you can put it's small fixes without PR :) |
|
@OpakAlex Why close? Of course one can fix this without the PR, but this change will be needed in the future. So it has to be merged! :-) |
|
We need PR with ember update, and include this. so for now we closed this PR because it's only update code, without update ember. |
|
allright! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.