[ENHANCEMENT] Open android project command #14

lib/commands/open.js

@@ -5,10 +5,15 @@ var path    = require('path');
 module.exports = {
   name: 'cordova:open',
   aliases: ['cdv:open'],
-  description: 'open the ios project with the default application',
+  description: 'Open the native project with the default application',
   works: 'insideProject',
 
-  run: function() {
-    return require('../tasks/open')(this.project)();
+  availableOptions: [
+    { name: 'platform', type: String, default: 'ios' },
+    { name: 'application', type: String}
+  ],
+
+  run: function(options) {
+    return require('../tasks/open')(this.project, options.platform, options.application)();
   }
 };

lib/tasks/open.js

@@ -1,13 +1,21 @@
 'use strict';
 
-var runCommand = require('../utils/run-command');
-var path       = require('path');
+var Promise        = require('../ext/promise');
+var path           = require('path');
+var runCommand     = require('../utils/run-command');
+var getOpenCommand = require('../utils/open');
 
-module.exports = function(project) {
+module.exports = function(project, platform, application) {
   var projectPath, command;
+  if (platform === 'ios') {
+    projectPath = path.join(project.root, 'cordova', 'platforms/ios/*.xcodeproj');
+  } else if (platform === 'android') {
+    projectPath = path.join(project.root, 'cordova', 'platforms/android/.project');
+  } else {
+    return Promise.reject(new Error('The ' + platform + ' platform is not supported. Please use "ios" or "android"'));
+  }
 
-  projectPath = path.join(project.root, 'cordova', 'platforms/ios/*.xcodeproj');
+  var command = getOpenCommand(projectPath, application);
 
-  command = 'open ' + projectPath;
-  return runCommand(command, 'Opening ios project with the default application');
+  return runCommand(command, 'Opening ' + platform + ' project with the default application');
 };

lib/utils/open.js

@@ -0,0 +1,42 @@
+'use strict';
+/*
+  This file needs to be removed when issue https://github.com/pwnall/node-open/issues/30
+  is resolved, original file can be seen here:
+  https://github.com/pwnall/node-open/blob/0c3ad272bfbc163cce8806e64630c623a9cfd8f4/lib/open.js
+*/
+module.exports = function(target, appName) {
+  var opener;
+
+  switch (process.platform) {
+    case 'darwin':
+      if (appName) {
+        opener = 'open -a "' + escape(appName) + '"';
+      } else {
+        opener = 'open';
+      }
+      break;
+    case 'win32':
+      // if the first parameter to start is quoted, it uses that as the title
+      // so we pass a blank title so we can quote the file we are opening
+      if (appName) {
+        opener = 'start "" "' + escape(appName) + '"';
+      } else {
+        opener = 'start';
+      }
+      break;
+    default:
+      if (appName) {
+        opener = escape(appName);
+      } else {
+        // use Portlands xdg-open everywhere else
+        opener = 'xdg-open';
+      }
+      break;
+  }
+
+  if (process.env.SUDO_USER) {
+    opener = 'sudo -u ' + process.env.SUDO_USER + ' ' + opener;
+  }
+
+  return opener + ' "' + target + '"';
+}

node-tests/unit/tasks/open-test.js

@@ -4,15 +4,73 @@ describe('Tasks - Open', function() {
     project = newProject();
   });
 
-  describe('darwin', function() {
-    it('runs correct command', function() {
-      var open = proxyquire('../../lib/tasks/open', {
-        '../utils/run-command': function(command) {
-          expect(command).to.eql('open project-root/cordova/platforms/ios/*.xcodeproj');
-        }
+  it('rejects when the platform isn\'t supported', function() {
+    var open = proxyquire('../../lib/tasks/open', {});
+
+    return open(project, 'fake-platform').catch(function(err) {
+      expect(err.toString()).to.match(/platform is not supported/);
+    });
+  });
+
+  describe('runs correct command on each platform', function() {
+    var platform;
+    before(function() {
+      platform = process.platform;
+    });
+
+    after(function() {
+      process.platform = platform;
+    });
+
+    describe('darwin', function() {
+      beforeEach(function() {
+        process.platform = 'darwin';
+      });
+
+      it('ios', function() {
+        return assertOpenCommand(project, 'ios', 'open "project-root/cordova/platforms/ios/*.xcodeproj"');
       });
 
-      return open(project);
+      it('android', function() {
+        return assertOpenCommand(project, 'android', 'open "project-root/cordova/platforms/android/.project"');
+      });
+    });
+
+    describe('win32', function() {
+      beforeEach(function() {
+        process.platform = 'win32';
+      });
+
+      it('ios', function() {
+        return assertOpenCommand(project, 'ios', 'start "project-root/cordova/platforms/ios/*.xcodeproj"');
+      });
+
+      it('android', function() {
+        return assertOpenCommand(project, 'android', 'start "project-root/cordova/platforms/android/.project"');
+      });
+    });
+
+    describe('other', function() {
+      beforeEach(function() {
+        process.platform = 'other';
+      });
+
+      it('ios', function() {
+        return assertOpenCommand(project, 'ios', 'xdg-open "project-root/cordova/platforms/ios/*.xcodeproj"');
+      });
+
+      it('android', function() {
+        return assertOpenCommand(project, 'android', 'xdg-open "project-root/cordova/platforms/android/.project"');
+      });
     });
   });
 });
+
+function assertOpenCommand(project, platform, assertion) {
+  var open = proxyquire('../../lib/tasks/open', {
+    '../utils/run-command': function(command) {
+      expect(command).to.eql(assertion);
+    }
+  });
+  return open(project, platform);
+}