Make JsonParser fail on empty (maybe filtered invalid) domains array …

…of MailDomainGroup. IQSS#6936
poikilotherm · Jun 10, 2020 · 09c7f64 · 09c7f64
1 parent 389324b
commit 09c7f64
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/src/main/java/edu/harvard/iq/dataverse/util/json/JsonParser.java b/src/main/java/edu/harvard/iq/dataverse/util/json/JsonParser.java
@@ -256,6 +256,8 @@ public MailDomainGroup parseMailDomainGroup(JsonObject obj) throws JsonParseExce
                     .map(JsonString::getString)
                     .filter(d -> DomainValidator.getInstance().isValid(d))
                     .collect(Collectors.toList());
+            if (domains.isEmpty())
+                throw new JsonParseException("Field domains may not be an empty array or contain invalid domains.");
             grp.setEmailDomains(domains);
         } else {
             throw new JsonParseException("Field domains is mandatory.");