Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Puppeteer, fix email/password fill, adjust Title selector to be <a> instead of H2 #9

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

justinkuntz
Copy link

Just ran this repo successfully after a few tweaks.

  • Yarn upgrade
  • Switch page.fill to page.type (likely a Puppeteer change?)
  • Update querySelector: const title = el.querySelector("a").innerText;
  • Small spelling fix for password

Hope this helps...thanks for the awesome utility!

@justinkuntz
Copy link
Author

Just realized these fixes (aside from the spelling) were addressed by the other pull request by rtorcato and devendra-karkar.

@Scrobwofl
Copy link

Scrobwofl commented Oct 14, 2022

Hi @justinkuntz , I'm trying to use this tool and it runs somewhat successfully with your changes, it allows me to login etc, but it finds zero components. I'm an amateur dev and have been looking at it all day but can't find the issue. Thought it might be the deprecated initEvent, but updated constructor method gives same result. Tried internet time machine to look at the code when you committed and i can't see any major changes in the page breadcrumb. Any advice on where i should look as a more experienced dev?

@wzulfikar
Copy link
Contributor

Hey @Scrobwofl, if you're still trying to use this, I made a PR (#11) that should work. Feel free to check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants