Add support for Swift Testing #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephencelis
commented
Jul 11, 2024
| @@ -101,17 +101,17 @@ | |||
| } | |||
|
|
|||
| public var now: Instant { | |||
| XCTFail("Unimplemented: \(self.name).now") | |||
| reportIssue("Unimplemented: \(self.name).now") | |||
There was a problem hiding this comment.
Now we could pass the proper file-line source context here, but:
- We need to pass them into the initializer.
- We need to update the
.unimplementedstatic to be a function. While this is technically a breaking change,.unimplementedonly recently started working in Swift 6 beta sinceany Clockdid not support it, so it might be an OK breaking change to make.
mbrandonw
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it so
TestClockandUnimplementedClockboth report failures to the new Swift Testing framework.