Remove redundant error type in ReusableFavoritingTests.swift #1538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
85
to
80
| title: TextState("Favoriting failed.") | ||
| title: TextState(FavoriteError().localizedDescription) |
There was a problem hiding this comment.
Can you revert this one change assuming things still pass with "Favoriting failed."? We prefer to assert against concrete data where possible,
There was a problem hiding this comment.
Sure! I reverted it.
stephencelis
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I removed a redundant
FavoriteErrorstruct in ReusableFavoritingTests.swiftAnd changed the hard-coded AlertState's title so that it's easier to maintain.