Qualify Send as Effect(Task)<Action>.Send
#1926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
I've also fixed a few tests expectations. I don't think they were induced by #1911. It would probably be preferable to update all the internal |
|
As |
This should be more resilient when this extension will become an `Effect` extension rather than `EffectPublisher<_, Never>`.
|
If you prefer to push only the fix from |
tgrapperon
changed the title
Send as Effect(Task)<Send>Send as Effect(Task)<Action>.Send
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've qualified a few missed occurrences of unqualified
Sendthat I missed in #1911. I can rebase these changes inmainif you prefer.I've used
EffectTaskas this alias is still used through the codebase.This should fix #1924