Assorted fixes for collections of state #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephencelis
commented
May 6, 2020
Member
Author
stephencelis
left a comment
stephencelis
left a comment
There was a problem hiding this comment.
Here's a quick overview of the changes!
Comment on lines
+197
to
+207
| // NB: This does not need to be a fatal error because of the index subscript that follows it. | ||
| assert( | ||
| index < globalState[keyPath: toLocalState].endIndex, | ||
| """ | ||
| Index out of range. This can happen when a reducer that can remove the last element from \ | ||
| an array is then combined with a "forEach" from that array. To avoid this and other \ | ||
| index-related gotchas, consider using an "IdentifiedArray" of state instead. Or, combine \ | ||
| your reducers so that the "forEach" comes before any reducer that can remove elements from \ | ||
| its array. | ||
| """ | ||
| ) |
Member
Author
There was a problem hiding this comment.
This error message should help fix #21. We can finesse the wording if any of it could be improved.
| return self.optional | ||
| .reducer( | ||
| &globalState[keyPath: toLocalState][id], | ||
| &globalState[keyPath: toLocalState][id: id], |
Member
Author
There was a problem hiding this comment.
I've updated the interface to take an explicit id parameter to avoid any ambiguity for Int-based ids.
Comment on lines
99
to
104
| _modify { | ||
| yield &self.dictionary[id] | ||
| if self.dictionary[id] == nil { | ||
| self.ids.removeAll(where: { $0 == id }) | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
We weren't properly cleaning up the ids array when nil-ing out elements.
| } | ||
| } | ||
|
|
||
| @discardableResult |
Member
Author
There was a problem hiding this comment.
Stumbled upon this warning when writing tests.
|
|
||
| public mutating func remove(atOffsets offsets: IndexSet) { | ||
| for offset in offsets { | ||
| for offset in offsets.reversed() { |
Member
Author
There was a problem hiding this comment.
Tests caught a bug here, as well!
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21 and a few other things, which I will review.