Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Child store caching improvements #2627

Merged
merged 7 commits into from
Dec 7, 2023
Merged

Child store caching improvements #2627

merged 7 commits into from
Dec 7, 2023

Conversation

stephencelis
Copy link
Member

This PR supersedes #2626. It:

  • Only caches stores via ScopeID instead of the more nebulous AnyHashable.
  • Uses store caching with more view modifiers, e.g. various presentation modifiers.
  • Leverages store caching/invalidation for the last non-nil value (rather than managing a local copy of state).

@acosmicflamingo
Copy link
Contributor

acosmicflamingo commented Dec 6, 2023

LGTM!

Edit: half-joking as if I'm a primary contributor to this repo, but I did use this PR in my own codebase and everything works perfectly

@stephencelis
Copy link
Member Author

Tested with isowords and things seem to be behaving well with the changes.

@stephencelis stephencelis merged commit c2a27dc into main Dec 7, 2023
@stephencelis stephencelis deleted the more-scope-caching branch December 7, 2023 20:39
@stephencelis stephencelis added the store tree Related to our store tree release. label Dec 7, 2023
cgrindel-self-hosted-renovate bot referenced this pull request in cgrindel/rules_swift_package_manager Dec 8, 2023
…ure to from: "1.5.2" (#792)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[pointfreeco/swift-composable-architecture](https://togithub.com/pointfreeco/swift-composable-architecture)
| patch | `from: "1.5.1"` -> `from: "1.5.2"` |

---

### Release Notes

<details>
<summary>pointfreeco/swift-composable-architecture
(pointfreeco/swift-composable-architecture)</summary>

###
[`v1.5.2`](https://togithub.com/pointfreeco/swift-composable-architecture/releases/tag/1.5.2)

[Compare
Source](https://togithub.com/pointfreeco/swift-composable-architecture/compare/1.5.1...1.5.2)

#### What's Changed

- Performance: cache more child stores and avoid extra copies of
child/presented state
([https://github.com/pointfreeco/swift-composable-architecture/pull/2627](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2627)).
- Infrastructure: 1.5 migration guide updates
([https://github.com/pointfreeco/swift-composable-architecture/pull/2615](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2615));
link to observation beta in README
([https://github.com/pointfreeco/swift-composable-architecture/pull/2616](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2616)).

**Full Changelog**:
pointfreeco/swift-composable-architecture@1.5.1...1.5.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
store tree Related to our store tree release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants