Revert "Fix Store leak when async effect is in flight (#2643)" #2648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
stephencelis
force-pushed
the
revert-2643
branch
from
92b64a8 to
dff2382
Compare
mbrandonw
approved these changes
Dec 12, 2023
3 tasks
cgrindel-self-hosted-renovate bot
referenced
this pull request
in cgrindel/rules_swift_package_manager
Dec 13, 2023
…ure to from: "1.5.5" (#802) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [pointfreeco/swift-composable-architecture](https://togithub.com/pointfreeco/swift-composable-architecture) | patch | `from: "1.5.4"` -> `from: "1.5.5"` | --- ### Release Notes <details> <summary>pointfreeco/swift-composable-architecture (pointfreeco/swift-composable-architecture)</summary> ### [`v1.5.5`](https://togithub.com/pointfreeco/swift-composable-architecture/releases/tag/1.5.5) [Compare Source](https://togithub.com/pointfreeco/swift-composable-architecture/compare/1.5.4...1.5.5) #### What's Changed - Fixed: A retain cycle fix in 1.5.4 could lead to regressions where stores can deinitialize before actions make it back into the system. This has been reverted and will have to be addressed in the future ([https://github.com/pointfreeco/swift-composable-architecture/pull/2648](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2648)). **Full Changelog**: pointfreeco/swift-composable-architecture@1.5.4...1.5.5 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit b86012c.
While we would like to adopt this change, it is incompatible with uncached stores, which are still the dominant kind of store these days.
We can revisit this in 2.0, when we have fully removed the old scoping operations and when stores have more defined lifecycles, cached in their parents.