Basics of composition in the "essentials" tutorial #2659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandonw
commented
Dec 17, 2023
| @@ -508,6 +508,28 @@ case .startButtonTapped: | |||
| This greatly reduces the bandwidth of actions being sent into the system so that you are not | |||
| incurring unnecessary costs for sending actions. | |||
|
|
|||
| Another example that comes up often is sliders. If done in the most direct way, by deriving a | |||
There was a problem hiding this comment.
Unrelated to the core of this PR, but this came up in slack today and thought it would be good to add. I think the example before this of limiting actions in effects is a little complex, and so a simpler example of a Slider would be nice.
mbrandonw
commented
Dec 17, 2023
| @@ -114,7 +114,7 @@ | |||
| ``ComposableArchitecture/PresentationState`` that allows you to modify the data in the case | |||
| of any enum. | |||
|
|
|||
| > Tip: See ``ComposableArchitecture/PresentationState/subscript(case:)-2sweb`` for | |||
| > Tip: See ``ComposableArchitecture/PresentationState/subscript(case:)-7uqte`` for | |||
There was a problem hiding this comment.
unrelated to this PR, but this was pointing to the deprecated subscript.
mbrandonw
commented
Dec 17, 2023
| @@ -92,7 +92,26 @@ public struct PresentationState<State> { | |||
|
|
|||
| /// Accesses the value associated with the given case for reading and writing. | |||
| /// | |||
| /// > Note: Accessing the wrong case will result in a runtime warning. | |||
| /// If you using the techniques of tree-based navigation (see <doc:TreeBasedNavigation>), then | |||
There was a problem hiding this comment.
Just beefing up these docs a bit.
mbrandonw
commented
Dec 17, 2023
| @@ -55,7 +55,26 @@ public struct StackState<Element> { | |||
|
|
|||
| /// Accesses the value associated with the given id and case for reading and writing. | |||
| /// | |||
| /// > Note: Accessing the wrong case will result in a runtime warning. | |||
| /// When using stack-based navigation (see <doc:StackBasedNavigation>) you will typically have a | |||
mbrandonw
commented
Dec 17, 2023
| @@ -102,11 +106,11 @@ import SwiftUI | |||
| /// | |||
| /// If your view does not need access to any state in the store and only needs to be able to send | |||
| /// actions, then you should consider not using ``WithViewStore`` at all. Instead, you can send | |||
| /// actions to a ``Store`` in a lightweight way like so: | |||
| /// actions directly to a ``Store`` like so: | |||
There was a problem hiding this comment.
Noticed that there's a more modern way of handling this.
stephencelis
approved these changes
Dec 19, 2023
cgrindel-self-hosted-renovate bot
referenced
this pull request
in cgrindel/rules_swift_package_manager
Dec 21, 2023
…ure to from: "1.5.6" (#821) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [pointfreeco/swift-composable-architecture](https://togithub.com/pointfreeco/swift-composable-architecture) | patch | `from: "1.5.5"` -> `from: "1.5.6"` | --- ### Release Notes <details> <summary>pointfreeco/swift-composable-architecture (pointfreeco/swift-composable-architecture)</summary> ### [`v1.5.6`](https://togithub.com/pointfreeco/swift-composable-architecture/releases/tag/1.5.6) [Compare Source](https://togithub.com/pointfreeco/swift-composable-architecture/compare/1.5.5...1.5.6) #### What's Changed > \[!IMPORTANT] > While this release contains no additions or breaking changes to the Composable Architecture's APIs, the `Store.scope` operation has been significantly refactored for performance. While we have vetted these changes in our own test suites and applications, and have worked with members of the community to test these changes before this release, please thoroughly test the view layer of your applications after upgrading to this version, and before releasing your application to production. > > See [#​2664](https://togithub.com/pointfreeco/swift-composable-architecture/issues/2664) for more details on the change. - Performance: Overhaul store scope communication ([https://github.com/pointfreeco/swift-composable-architecture/pull/2664](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2664)). - Infrastructure: Update sample code to use the `@DependencyClient` macro ([https://github.com/pointfreeco/swift-composable-architecture/pull/2653](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2653)). - Infrastructure: Update migration guide with more information about applying `@CasePathable` to enums ([https://github.com/pointfreeco/swift-composable-architecture/pull/2672](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2672)). - Infrastructure: Add basics of composition to the "essentials" tutorial ([https://github.com/pointfreeco/swift-composable-architecture/pull/2659](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2659)). **Full Changelog**: pointfreeco/swift-composable-architecture@1.5.5...1.5.6 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realized that there was an opportunity to do a basic intro to composition during the essentials tutorial. And then the navigation tutorial provides a more advanced look into composition.