-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a SharedReader.constant helper. #3127
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephencelis
approved these changes
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm open to it for discoverability, though we don't have to rush to merge if we want to think on it longer.
cgrindel-self-hosted-renovate bot
referenced
this pull request
in cgrindel/rules_swift_package_manager
Jul 2, 2024
…ure to from: "1.11.2" (#1137) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [pointfreeco/swift-composable-architecture](https://togithub.com/pointfreeco/swift-composable-architecture) | minor | `from: "1.10.4"` -> `from: "1.11.2"` | --- ### Release Notes <details> <summary>pointfreeco/swift-composable-architecture (pointfreeco/swift-composable-architecture)</summary> ### [`v1.11.2`](https://togithub.com/pointfreeco/swift-composable-architecture/releases/tag/1.11.2) [Compare Source](https://togithub.com/pointfreeco/swift-composable-architecture/compare/1.11.1...1.11.2) #### What's Changed - Fixed: Avoid potential sendability warnings in Swift 6 mode ([https://github.com/pointfreeco/swift-composable-architecture/pull/3167](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3167)). - Fixed: `PersistenceKeyDefault` no longer uses the loaded value as an initial value (thanks [@​fdzsergio](https://togithub.com/fdzsergio), [https://github.com/pointfreeco/swift-composable-architecture/pull/3174](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3174)). - Fixed: Address a potential deadlock by isolating `Shared.withLock` to the main actor ([https://github.com/pointfreeco/swift-composable-architecture/pull/3178](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3178)). - Fixed: Disfavor `Shared`'s optional dynamic member lookup ([https://github.com/pointfreeco/swift-composable-architecture/pull/3170](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3170)). Note that this fix may be source breaking. See the [migration guide](https://pointfreeco.github.io/swift-composable-architecture/main/documentation/composablearchitecture/migratingto1.11) for more details. - Fixed: Don't over-observe app storage mutations ([https://github.com/pointfreeco/swift-composable-architecture/pull/3186](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3186)). - Fixed: `$shared.elements` is now stable based on identity, and restricted to identified arrays ([https://github.com/pointfreeco/swift-composable-architecture/pull/3187](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3187)). - Infrastructure: Drop Swift <5.9 support ([https://github.com/pointfreeco/swift-composable-architecture/pull/3185](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3185)). Xcode 15 has been required for app submission since April, so we can keep our Swift support in line with Apple's. - Infrastructure: 1.11 migration guide fixes (thanks [@​larryonoff](https://togithub.com/larryonoff), [https://github.com/pointfreeco/swift-composable-architecture/pull/3184](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3184)); tutorial typo fixes (thanks [@​meltsplit](https://togithub.com/meltsplit), [https://github.com/pointfreeco/swift-composable-architecture/pull/3161](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3161)). #### New Contributors - [@​meltsplit](https://togithub.com/meltsplit) made their first contribution in [https://github.com/pointfreeco/swift-composable-architecture/pull/3161](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3161) - [@​fdzsergio](https://togithub.com/fdzsergio) made their first contribution in [https://github.com/pointfreeco/swift-composable-architecture/pull/3174](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3174) **Full Changelog**: pointfreeco/swift-composable-architecture@1.11.1...1.11.2 ### [`v1.11.1`](https://togithub.com/pointfreeco/swift-composable-architecture/releases/tag/1.11.1) [Compare Source](https://togithub.com/pointfreeco/swift-composable-architecture/compare/1.11.0...1.11.1) #### What's Changed - Fixed: Support swift-syntax from 600.0.0-latest ([https://github.com/pointfreeco/swift-composable-architecture/pull/3160](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3160)). - Fixed: `Shared.withLock` now pass values by continuation ([https://github.com/pointfreeco/swift-composable-architecture/pull/3154](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3154)). - Infrastructure: Clean up DocC and link to new migration guide in README ([https://github.com/pointfreeco/swift-composable-architecture/pull/3153](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3153)); SyncUp tutorial fixes (thanks [@​dafurman](https://togithub.com/dafurman), [https://github.com/pointfreeco/swift-composable-architecture/pull/3139](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3139); thanks [@​RuiAAPeres](https://togithub.com/RuiAAPeres), [https://github.com/pointfreeco/swift-composable-architecture/pull/3159](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3159)); note Swift bug in documentation ([https://github.com/pointfreeco/swift-composable-architecture/pull/3157](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3157)). #### New Contributors - [@​RuiAAPeres](https://togithub.com/RuiAAPeres) made their first contribution in [https://github.com/pointfreeco/swift-composable-architecture/pull/3159](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3159) **Full Changelog**: pointfreeco/swift-composable-architecture@1.11.0...1.11.1 ### [`v1.11.0`](https://togithub.com/pointfreeco/swift-composable-architecture/releases/tag/1.11.0) [Compare Source](https://togithub.com/pointfreeco/swift-composable-architecture/compare/1.10.4...1.11.0) #### What's Changed - Added: `Shared.withLock`, for mutating shared state from asynchronous contexts ([https://github.com/pointfreeco/swift-composable-architecture/pull/3136](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3136)). Direct mutations from asynchronous contexts is marked unavailable and will be an error in Swift 6. - Added: `SharedReader.constant` ([https://github.com/pointfreeco/swift-composable-architecture/pull/3127](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3127)). - Added: `$store.scope` will now emit a warning when a dismiss action doesn't `nil` out a child feature, suggesting a `Reducer.ifLet` (or parent integration) is missing ([https://github.com/pointfreeco/swift-composable-architecture/pull/3089](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3089)). - Deprecated: `Shared`'s optional dynamic member lookup overload has been deprecated in favor of a `Binding.init` that unwraps optional values ([https://github.com/pointfreeco/swift-composable-architecture/pull/3145](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3145)). - Fixed: Avoid crash when using `.appStorage` with a `URL` value (thanks [@​pwszebor](https://togithub.com/pwszebor), [https://github.com/pointfreeco/swift-composable-architecture/pull/3098](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3098)). - Fixed: Worked around a build failure when integrating with Tuist ([https://github.com/pointfreeco/swift-composable-architecture/pull/3140](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3140)). - Infrastructure: Tutorial fixes ([https://github.com/pointfreeco/swift-composable-architecture/pull/3076](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3076); thanks [@​MartinMoizard](https://togithub.com/MartinMoizard), [https://github.com/pointfreeco/swift-composable-architecture/pull/3078](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3078); [https://github.com/pointfreeco/swift-composable-architecture/pull/3072](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3072); thanks [@​hmhv](https://togithub.com/hmhv), [https://github.com/pointfreeco/swift-composable-architecture/pull/3091](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3091); thanks [@​gibachan](https://togithub.com/gibachan), [https://github.com/pointfreeco/swift-composable-architecture/pull/3099](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3099); thanks [@​btr-better](https://togithub.com/btr-better), [https://github.com/pointfreeco/swift-composable-architecture/pull/3107](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3107); thanks [@​woxtu](https://togithub.com/woxtu), [https://github.com/pointfreeco/swift-composable-architecture/pull/3119](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3119), [https://github.com/pointfreeco/swift-composable-architecture/pull/3123](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3123); [https://github.com/pointfreeco/swift-composable-architecture/pull/3135](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3135); [https://github.com/pointfreeco/swift-composable-architecture/pull/3141](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3141); [https://github.com/pointfreeco/swift-composable-architecture/pull/3148](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3148)); DocC fixes ([https://github.com/pointfreeco/swift-composable-architecture/pull/3085](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3085); [https://github.com/pointfreeco/swift-composable-architecture/pull/3087](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3087); thanks [@​JOyo246](https://togithub.com/JOyo246), [https://github.com/pointfreeco/swift-composable-architecture/pull/3092](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3092); thanks [@​leeari95](https://togithub.com/leeari95), [https://github.com/pointfreeco/swift-composable-architecture/pull/3110](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3110); [https://github.com/pointfreeco/swift-composable-architecture/pull/3138](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3138)); README fixes (thanks [@​Matt54](https://togithub.com/Matt54), [https://github.com/pointfreeco/swift-composable-architecture/pull/3129](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3129)); expose some navigation APIs with `@_spi(Internal)` (thanks [@​Alex293](https://togithub.com/Alex293), [https://github.com/pointfreeco/swift-composable-architecture/pull/3097](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3097)). #### New Contributors - [@​MartinMoizard](https://togithub.com/MartinMoizard) made their first contribution in [https://github.com/pointfreeco/swift-composable-architecture/pull/3078](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3078) - [@​JOyo246](https://togithub.com/JOyo246) made their first contribution in [https://github.com/pointfreeco/swift-composable-architecture/pull/3092](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3092) - [@​pwszebor](https://togithub.com/pwszebor) made their first contribution in [https://github.com/pointfreeco/swift-composable-architecture/pull/3098](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3098) - [@​Alex293](https://togithub.com/Alex293) made their first contribution in [https://github.com/pointfreeco/swift-composable-architecture/pull/3097](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3097) - [@​gibachan](https://togithub.com/gibachan) made their first contribution in [https://github.com/pointfreeco/swift-composable-architecture/pull/3099](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3099) - [@​leeari95](https://togithub.com/leeari95) made their first contribution in [https://github.com/pointfreeco/swift-composable-architecture/pull/3110](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3110) - [@​btr-better](https://togithub.com/btr-better) made their first contribution in [https://github.com/pointfreeco/swift-composable-architecture/pull/3107](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3107) - [@​Matt54](https://togithub.com/Matt54) made their first contribution in [https://github.com/pointfreeco/swift-composable-architecture/pull/3129](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3129) **Full Changelog**: pointfreeco/swift-composable-architecture@1.10.4...1.11.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #3124, this helper may help when needing to provide
SharedReader
values in previews and tests.At the end of the day it is only a helper for doing
Shared(value).reader
, so maybe not worth it.