Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Soft-deprecate Store.ifLet #3382

Merged
merged 5 commits into from
Sep 13, 2024
Merged

Soft-deprecate Store.ifLet #3382

merged 5 commits into from
Sep 13, 2024

Conversation

stephencelis
Copy link
Member

We can prefer observe and if let store.scope now.

@stephencelis
Soft-deprecate Store.ifLet
ae752a7 
We can prefer `observe` and `if let store.scope` now.
mbrandonw
mbrandonw approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@mbrandonw mbrandonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we get a migration guide in for this too?

@stephencelis
Copy link
Member Author

@mbrandonw Done!

@stephencelis stephencelis merged commit dcecad3 into main Sep 13, 2024
12 checks passed
@stephencelis stephencelis deleted the deprecate-uikit-store-iflet branch September 13, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrandonw mbrandonw mbrandonw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephencelis @mbrandonw