[Building Sync-ups Tutorial] fixes in "Record meeting" chapter #3582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change foregroundColor to foregroundStyle. Update the delete button to use a destructive role.
and add missing Foundation import
FredericRuaudel
commented
Feb 2, 2025
| @@ -1,4 +1,5 @@ | |||
| import ComposableArchitecture | |||
| import Foundation | |||
There was a problem hiding this comment.
📓 Added to compile de Date
FredericRuaudel
commented
Feb 2, 2025
Comment on lines
-48
to
+57
| $0.syncUp.meetings.insert( | ||
| Meeting( | ||
| id: UUID(0), | ||
| date: Date(timeIntervalSince1970: 1234567890), | ||
| transcript: "" | ||
| ), | ||
| at: 0 | ||
| ) | ||
| $0.$syncUp.withLock { | ||
| $0.meetings = [ | ||
| Meeting( | ||
| id: UUID(0), | ||
| date: Date(timeIntervalSince1970: 1234567890), | ||
| transcript: "" | ||
| ) | ||
| ] | ||
| } |
There was a problem hiding this comment.
📓 I've slightly change the assertion by matching the exact array of meeting to match your recommandation to test against the real result instead of mimicking the code in production.
FredericRuaudel
commented
Feb 2, 2025
Comment on lines
-31
to
-42
|
|
||
| #Preview { | ||
| AppView( | ||
| store: Store( | ||
| initialState: App.State( | ||
| syncUpsList: SyncUpsList.State() | ||
| ) | ||
| ) { | ||
| App() | ||
| } | ||
| ) | ||
| } |
There was a problem hiding this comment.
📓 I removed this preview because it brings no special changes in the tutorial and was creating a confusing diff.
FredericRuaudel
commented
Feb 2, 2025
| Button("Delete") { | ||
| Button("Delete", role: .destructive) { |
There was a problem hiding this comment.
📓 These changes are here to match the changes made in previous part of the tutorial
FredericRuaudel
commented
Feb 2, 2025
Comment on lines
-5
to
-6
|
|
||
| <!-- @Image(source: <#file#>, alt: "<#accessible description#>")--> |
There was a problem hiding this comment.
📓 useless commented code ? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Following my last PR, I'm currently reviewing the "Building Sync-ups" tutorial and so far, there is a lot of changes so I've splitted up into one PR per chapter to ease the review of them, finishing with the "Record meeting" chapter here…
Changes Made:
foregroundColortoforegroundStyle. Additionally, modified the delete button to utilize a destructive role to match previous changes.withLockfor modifying shared syncUp instances.And this should conclude this review… Thanks for your review of all these changes! 🙏
Note: When trying the last steps of the tests where we cancel the long living timer effect, my test was already passing without the cancel call. It seems to be useless now or maybe the production code had a regression on this part ? Anyway, I left it as an insightful example of how to deal with these problem which tends to occurs sometimes…