Print object identity in diff #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephencelis
commented
Oct 22, 2021
| extension ObjectIdentifier: CustomDumpStringConvertible { | ||
| public var customDumpDescription: String { | ||
| self.debugDescription | ||
| .replacingOccurrences(of: "0x0*", with: "0x", options: .regularExpression) |
Member
Author
There was a problem hiding this comment.
Shortens ObjectIdentifier(0x00000000000deadbeef) to ObjectIdentifier(0xdeadbeef).
stephencelis
commented
Oct 22, 2021
Comment on lines
+314
to
+315
| let showObjectIdentifiers = lhsItem != rhsItem | ||
| && isMirrorEqual(Array(lhsMirror.children), Array(rhsMirror.children)) |
Member
Author
There was a problem hiding this comment.
We'll only diff/print object identifiers if all the exposed properties are equal. This should avoid noise in classes where are objects are equatable across identity.
stephencelis
commented
Oct 22, 2021
Sources/CustomDump/Diff.swift
Outdated
| _ transform: (inout Mirror.Child, Int) -> Void = { _, _ in } | ||
| ) { | ||
| guard !lhsMirror.children.isEmpty || !rhsMirror.children.isEmpty | ||
| guard !isMirrorEqual(Array(lhsMirror.children), Array(rhsMirror.children)) |
Member
Author
There was a problem hiding this comment.
Not sure if there's a more performant approach...
stephencelis
commented
Oct 22, 2021
| guard !isMirrorEqual(Array(lhsMirror.children), Array(rhsMirror.children)) | ||
| else { | ||
| print( | ||
| "// Not equal but no difference detected:" |
Member
Author
There was a problem hiding this comment.
We'll now print a message when no difference is detected.
stephencelis
commented
Oct 22, 2021
| """ | ||
| // Not equal but no difference detected: | ||
| - NeverEqualUser(…) | ||
| + NeverEqualUser(…) |
Member
Author
There was a problem hiding this comment.
We could expand the properties here to aid a bit more in debugging...
mbrandonw
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NSObjects are equatable by object identity by default, which can lead todiffreturning a confusing string with no insertions/removals when all properties look the same, as brought up in this TCA discussion. This PR attempts to surface the object identity mismatch when everything else is the same.