Expose Testing test identifier from test context #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephencelis
commented
Sep 4, 2024
| /// Testing framework, or Xcode's XCTest framework. | ||
| public enum TestContext { | ||
| /// The Swift Testing framework. | ||
| case swiftTesting | ||
| case swiftTesting(Testing) |
There was a problem hiding this comment.
Technically this is a breaking change for folks referring directly to this .swiftTesting case, so we could introduce a new set of alternate APIs here instead.
If someone was merely switching over the cases in their test helper it should be source compatible, though.
stephencelis
commented
Sep 4, 2024
Comment on lines
8
to
13
| #expect(TestContext.current == .swiftTesting) | ||
| switch TestContext.current { | ||
| case .swiftTesting: | ||
| #expect(true) | ||
| default: | ||
| Issue.record() | ||
| } |
There was a problem hiding this comment.
An example API breakage and fix.
mbrandonw
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be useful to distinguish between tests in addition to knowing the test context, so let's surface some of that data.
One example use case, preventing global state from bleeding between tests in our Dependencies library: pointfreeco/swift-dependencies#269