Skip to content

Fix bindable constraints for visionOS #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephencelis merged 3 commits into from
Aug 12, 2025
Merged

Fix bindable constraints for visionOS #152

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9aaae64
Avoid os_log decoding errors in perception check
stephencelis Aug 4, 2025
a19c5c6
Fix bindable constraints for visionOS
stephencelis Aug 12, 2025
115b65d
Merge remote-tracking branch 'origin/main' into fix-visionos
stephencelis Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions Sources/PerceptionCore/SwiftUI/Bindable.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
@available(visionOS, unavailable)
@dynamicMemberLookup
@propertyWrapper
public struct Bindable<Value: Perceptible> {
public struct Bindable<Value> {
@ObservedObject fileprivate var observer: Observer<Value>

/// The wrapped object.
Expand All @@ -52,27 +52,31 @@
dynamicMember keyPath: ReferenceWritableKeyPath<Value, Subject>
) -> Binding<Subject> where Value: AnyObject {
#if DEBUG && canImport(SwiftUI)
$observer.object[
isPerceptionTracking: _PerceptionLocals.isInPerceptionTracking,
keyPath: keyPath
]
func open<V: Perceptible>(_: V.Type) -> Binding<Subject> {
($observer as! ObservedObject<Observer<V>>.Wrapper).object[
isPerceptionTracking: _PerceptionLocals.isInPerceptionTracking,
keyPath: unsafeDowncast(keyPath, to: ReferenceWritableKeyPath<V, Subject>.self)
]
}
guard let valueType = Value.self as? any Perceptible.Type else { fatalError() }
return open(valueType)
#else
$observer.object[dynamicMember: keyPath]
#endif
}

/// Creates a bindable object from an observable object.
public init(wrappedValue: Value) where Value: AnyObject {
public init(wrappedValue: Value) where Value: AnyObject & Perceptible {
self.observer = Observer(wrappedValue)
}

/// Creates a bindable object from an observable object.
public init(_ wrappedValue: Value) where Value: AnyObject {
public init(_ wrappedValue: Value) where Value: AnyObject & Perceptible {
self.init(wrappedValue: wrappedValue)
}

/// Creates a bindable from the value of another bindable.
public init(projectedValue: Bindable<Value>) where Value: AnyObject {
public init(projectedValue: Bindable<Value>) where Value: AnyObject & Perceptible {
self = projectedValue
}
}
Expand Down