Fix #440 Webview loading without delegate (option 2) #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 21, 2021 14:47
teameh
commented
Mar 23, 2021
| let webView = WKWebView() | ||
| webView.navigationDelegate = manipulatingWKWebViewNavigationDelegate | ||
|
|
||
| webView.load(URLRequest(url: URL(string: "https://www.pointfree.co")!)) |
There was a problem hiding this comment.
This loads an actual URL. Is that something you want to prevent in the unit tests? I can image you want to avoid it, but it's the best real life example..
teameh
changed the title
|
Thanks @stephencelis ! |
mac-gallagher
pushed a commit
to mac-gallagher/swift-snapshot-testing
that referenced
this pull request
Aug 22, 2021
…tfreeco#443) * Fix pointfreeco#440 - Improve WKWebView navigation delegate * Fix pointfreeco#440 - Replace WKWebView navigation delegate by observing wkWebView.isLoading Co-authored-by: Tieme van Veen <Tieme.vanVeen@triodos.com> Co-authored-by: Stephen Celis <stephen@stephencelis.com>
|
@stephencelis any idea when you're going to branch off the next release? |
|
@stephencelis? It would be great if we could use this in production |
|
\0/ thanks for merging 👯 😃 |
niil-qb
pushed a commit
to quickbit/swift-snapshot-testing
that referenced
this pull request
Feb 23, 2023
…tfreeco#443) * Fix pointfreeco#440 - Improve WKWebView navigation delegate * Fix pointfreeco#440 - Replace WKWebView navigation delegate by observing wkWebView.isLoading Co-authored-by: Tieme van Veen <Tieme.vanVeen@triodos.com> Co-authored-by: Stephen Celis <stephen@stephencelis.com>
Muhieddine-El-Kaissi
pushed a commit
to thumbtack/swift-snapshot-testing
that referenced
this pull request
Aug 8, 2024
…tfreeco#443) * Fix pointfreeco#440 - Improve WKWebView navigation delegate * Fix pointfreeco#440 - Replace WKWebView navigation delegate by observing wkWebView.isLoading Co-authored-by: Tieme van Veen <Tieme.vanVeen@triodos.com> Co-authored-by: Stephen Celis <stephen@stephencelis.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing #442 another time I suddenly thought it might also be possible to remove the delegate altogether and just observe the
isLoadingproperty on the WKWebView.I've implemented that in this PR. Happy to hear your thoughts. See comments below.