Expose snapshotDirectory parameter in assertSnapshot methods
#934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm aware of the intention of the publicly available `verifySnapshot` method that exposes this parameter, but as consumers of the library we tend to use `assertSnapshot` instead. `assertSnapshot` implementation has a very straightforward implementation that internally uses `verifySnapshot`, but now custom implementations also need to be aware if the custom method is used on a XCTest or SwiftTesting context. This library already handles that variation, then simply exposing this parameter doesn't break the API and makes sure consumers keep the correct behavior of `assertSnapshots` in context where we need to modify the `snapshotDirectory`, like in Xcode Cloud.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm aware of the intention of the publicly available
verifySnapshotmethod that exposes this parameter, but as consumers of the library we tend to useassertSnapshotinstead.assertSnapshotimplementation has a very straightforward implementation that internally usesverifySnapshot, but now custom implementations also need to be aware if the custom method is used on a XCTest or SwiftTesting context.This library already handles that variation, then simply exposing this parameter doesn't break the API and makes sure consumers keep the correct behavior of
assertSnapshotsin context where we need to modify thesnapshotDirectory, like in Xcode Cloud.