Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

WIP: extend/rewrite the script for DIN41612 connectors #219

Open
wants to merge 50 commits into
base: master
Choose a base branch
from

Conversation

hvraven
Copy link
Contributor

@hvraven hvraven commented Nov 13, 2018

I am currently working on the addition of further series of the DIN41612 connectors. This script was started mostly from scratch, but follows the design generated by the existing version.

There are still some issues to sort out, so this is not ready for merge yet. I would like to keep the style discussion to the footprint PR to keep it contained in one place.

@codeclimate
Copy link

codeclimate bot commented Nov 13, 2018

Code Climate has analyzed commit 99af657 and detected 0 issues on this pull request.

View more on Code Climate.

@evanshultz
Copy link
Collaborator

@lorem-ipsum
Please make sure that all TODO items which are not for future families of parts intentionally left out are addressed.

Also, I would be quite happy if you can make use of https://github.com/pointhi/kicad-footprint-generator/blob/master/scripts/tools/global_config_files/config_KLCv3.0.yaml and https://github.com/pointhi/kicad-footprint-generator/blob/master/scripts/tools/footprint_text_fields.py for maintainability instead of putting these values inside this script. This seems to be an older script before we pulled out some global/general parameters for use across all scripts.

@hvraven
Copy link
Contributor Author

hvraven commented May 4, 2020

I went through the TODOs and updated them. No more immediate TODOs remaining.

I agree with your YAML suggestion. The last updates were just to get the currently existing footprints done for merging. In general the script needs quite some cleanup. My plan would be as follows:

  • Get the script done so that the currently working footprints can be merged
  • (Optional) Merge this to get the script in sync with the footprint repo
  • Clean it up, change to YAML
  • Extend with missing parts

@evanshultz
Copy link
Collaborator

@lorem-ipsum
I merged the footprints. Above you wrote that merging the script now is optional. Do you want to do it? I think that would set a good baseline where a future PR can handle the cleanup.

@hvraven
Copy link
Contributor Author

hvraven commented May 14, 2020

I agree, merging this would give a clear basis to build any future improvements on. Currently the branch has weird conflicts with the master branch. I will rebase it, then it is good to go.

hvraven added 23 commits May 14, 2020 10:13
now they are the max of Harting, ept and ERNI
copied the introductionary comment from the original script
for the F series pins would collide with the full outline, so we only
draw a partial outline.
hvraven added 27 commits May 14, 2020 10:13
standard requires 2.8 to 2.9 mm
ZB is the standardized version, ZD is an extension by some manufacturers
thats how the library is called in kicad-symbols
@hvraven
Copy link
Contributor Author

hvraven commented May 14, 2020

Currently this includes #473 . I left it in for now as there have been no arguments against it. But just to note. I also moved the script to scripts/Connector/Connector_DIN (from Connector_IEC_DIN) as this is how the library is called in the symbols repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants