-
Notifications
You must be signed in to change notification settings - Fork 176
WIP: extend/rewrite the script for DIN41612 connectors #219
base: master
Are you sure you want to change the base?
Conversation
Code Climate has analyzed commit 99af657 and detected 0 issues on this pull request. View more on Code Climate. |
@lorem-ipsum Also, I would be quite happy if you can make use of https://github.com/pointhi/kicad-footprint-generator/blob/master/scripts/tools/global_config_files/config_KLCv3.0.yaml and https://github.com/pointhi/kicad-footprint-generator/blob/master/scripts/tools/footprint_text_fields.py for maintainability instead of putting these values inside this script. This seems to be an older script before we pulled out some global/general parameters for use across all scripts. |
I went through the TODOs and updated them. No more immediate TODOs remaining. I agree with your YAML suggestion. The last updates were just to get the currently existing footprints done for merging. In general the script needs quite some cleanup. My plan would be as follows:
|
@lorem-ipsum |
I agree, merging this would give a clear basis to build any future improvements on. Currently the branch has weird conflicts with the master branch. I will rebase it, then it is good to go. |
currently only horizontal and many unchecked variants. But it works reference document: http://www.erni.com/fileadmin/medien/downloadcenter/din41612/ERNI-DIN41612-IEC60603-2-e.pdf
now they are the max of Harting, ept and ERNI
copied the introductionary comment from the original script
for the F series pins would collide with the full outline, so we only draw a partial outline.
This reverts commit e0ac0a8.
standard requires 2.8 to 2.9 mm
ZB is the standardized version, ZD is an extension by some manufacturers
thats how the library is called in kicad-symbols
Currently this includes #473 . I left it in for now as there have been no arguments against it. But just to note. I also moved the script to |
I am currently working on the addition of further series of the DIN41612 connectors. This script was started mostly from scratch, but follows the design generated by the existing version.
There are still some issues to sort out, so this is not ready for merge yet. I would like to keep the style discussion to the footprint PR to keep it contained in one place.