This repository has been archived by the owner on Oct 7, 2020. It is now read-only.
adds definition for Xilinx Kintex-7 BGA FPGAs #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 189a688 and detected 0 issues on this pull request. View more on Code Climate. |
This was referenced May 8, 2019
|
Hmm. Annoying. The packages look different in the drawing but we can't be sure if they're the same or not. Even though they share a name. I guess this is the best compromise. Weak sauce on Xilinx's part... Everything looks good here. Thanks! @pointhi |
|
@herostrat @pointhi |
|
@evanshultz yes, I have already prepared the footprints for the Zynq-7000 versions (which should be the last afaik) and had waited until this PR got merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details: KiCad/kicad-footprints#1560
Footprint PR: KiCad/kicad-footprints#1584
@evanshultz the next batch
Notes: I added Kintex and their page in the doc to the three footprints already added during the Artix batch.
I choose to keep the family in the description, as the footprint names do not seem to mean a lot to Xilinx. It could be that the same name for a different family can have a different 3d model in the future.