This repository has been archived by the owner on Oct 7, 2020. It is now read-only.
Add support for IDC headers #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Also added some missing variables -Only those with mounting holes are included as current clipping tools are inaqdeuate for non-symmetrical footprints (about pin 1 placement) with lines that could intersect a non-rectangular object
|
Code Climate has analyzed commit 40f7177 and detected 0 issues on this pull request. View more on Code Climate. |
5 tasks
-There are in the library now do don't want to leave anybody out -Also some minor commenting cleanup
- Also generate all footprints into dedicated folders
- Move commented line in make file
|
Added some other headers which existed before but the generator didn't make. I used a very simple method to avoid clipping pads with silk since the existing 'clipper' functions can't handle a polyline that is intersected by multiple objects. Screenshots of these footprints, along with all others, are at the footprint PR above. |
- Name mounting holes 'MH' (I think it should be 'MP', though) - Simplify suffix to '_MountHole' (may not be necessary) - Note DIN/IEC spec for these IDC footprints
- Add '-1MP' and remove trailing suffix for mounting hole (MH) footprints - Switch to 8mm MH pads - Split silk outline for horizontal latching footprints if the MH is big - Remove datasheet URLs for other parts
|
thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Footprint PR: KiCad/kicad-footprints#1586