Merge pull request #9 from pojntfx/feature/fix-close-race-conditions

Check if line channel is closed before sending to it

Hydrunfile

@@ -31,7 +31,7 @@ if [ "$1" = "go" ]; then
     make depend
 
     # Build
-    CGO_ENABLED=0 bagop -j "$(nproc)" -b "$2" -x '(android/*|ios/*|plan9/*|aix/*)' -p "make build/$2 DST=\$DST" -d out
+    CGO_ENABLED=0 bagop -j "$(nproc)" -b "$2" -x '(android/*|ios/*|plan9/*|aix/*|linux/loong64)' -p "make build/$2 DST=\$DST" -d out
 
     exit 0
 fi

pkg/wrtcconn/adapter.go

@@ -54,9 +54,10 @@ type Adapter struct {
 	config   *AdapterConfig
 	ctx      context.Context
 
-	cancel context.CancelFunc
-	done   bool
-	lines  chan []byte
+	cancel   context.CancelFunc
+	done     bool
+	doneSync sync.Mutex
+	lines    chan []byte
 
 	peers chan *Peer
 
@@ -96,6 +97,17 @@ func NewAdapter(
 	}
 }
 
+func (a *Adapter) sendLine(line []byte) {
+	a.doneSync.Lock()
+	defer a.doneSync.Unlock()
+
+	if a.done {
+		return
+	}
+
+	a.lines <- line
+}
+
 // Open connects the adapter to the signaler
 func (a *Adapter) Open() (chan string, error) {
 	settingEngine := webrtc.SettingEngine{}
@@ -253,7 +265,7 @@ func (a *Adapter) Open() (chan string, error) {
 						return
 					}
 
-					a.lines <- p
+					a.sendLine(p)
 
 					log.Debug().Str("address", u.String()).Str("id", id).Msg("Introduced to signaler")
 				}()
@@ -376,7 +388,7 @@ func (a *Adapter) Open() (chan string, error) {
 									}
 
 									go func() {
-										a.lines <- p
+										a.sendLine(p)
 
 										log.Debug().
 											Str("address", conn.RemoteAddr().String()).
@@ -506,7 +518,7 @@ func (a *Adapter) Open() (chan string, error) {
 									peerLock.Unlock()
 
 									go func() {
-										a.lines <- p
+										a.sendLine(p)
 
 										log.Debug().
 											Str("address", conn.RemoteAddr().String()).
@@ -606,7 +618,7 @@ func (a *Adapter) Open() (chan string, error) {
 									}
 
 									go func() {
-										a.lines <- p
+										a.sendLine(p)
 
 										log.Debug().
 											Str("address", conn.RemoteAddr().String()).
@@ -726,7 +738,7 @@ func (a *Adapter) Open() (chan string, error) {
 							}()
 
 							go func() {
-								a.lines <- p
+								a.sendLine(p)
 
 								log.Debug().
 									Str("address", conn.RemoteAddr().String()).