Ping the signaling server from the client #191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Send pings to be able to detect broken connections. No need for a pong, TCP will take care of that. Log the origin with "unknown packet type received" so we can see which clients are sending packets the server doesn't support (in this case it was ping from old clients?).
ErikSom
approved these changes
Feb 5, 2025
Caspervw
approved these changes
Feb 5, 2025
koenbollen
reviewed
Feb 5, 2025
|
That's not how loadbalancing works for a WebSocket. It either gets delivered or the loadbalancer kills the connection and the next ping will catch it. |
koenbollen
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send pings to be able to detect broken connections. No need for a pong, TCP will take care of that.
Log the origin with "unknown packet type received" so we can see which clients are sending packets the server doesn't support (in this case it was ping from old clients?).
Fixes #183