Fix minor issues found by LLMs #192
Merged
+5
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I used the following command to concatenate everything into one big
blob:
npx repomix --ignore ".github/,.parcel-cache/,dist/,docs/,node_modules/,TODO.md,yarn.lock,LISENCE,features/,.dockerignore,.gitignore"
Then I pasted it into various LLMs with this prompt:
Find any potential bugs or issues in this code:
<big blob here>
OpenAI O1: https://chatgpt.com/share/67a2f13f-eed4-8000-a7c5-2b3194a6bd42
Google Gemini: https://gist.github.com/erikdubbelboer/529ba1ab62e7c9603a84b454be595da9
DeepSeek R1: https://gist.github.com/erikdubbelboer/9487f4262a6aae9bcc3ae765b3e7d8b6
The prompt was too big for Claude 3.5 Sonnet.
Most "bugs" or issues it find are either wrong or irrelevant. For
example any concurrency or security issue in testproxy. Some things are
even wrong such as Gemini seeing a unicode character that isn't there.
ErikSom
approved these changes
Feb 5, 2025
Caspervw
approved these changes
Feb 5, 2025
Pedr0Rocha
reviewed
Feb 5, 2025
| if err == stores.ErrNoSuchTopic { | ||
| util.ReplyError(ctx, p.conn, &MissingRecipientError{ | ||
| Recipient: routing.Recipient, | ||
| Cause: err, | ||
| }) | ||
| } else if err != nil { | ||
| if err != nil { |
There was a problem hiding this comment.
This behaviour does not look exactly the same, are we supposed to return the error even when it's ErrNoSuchTopic? If so, nice catch from the lib.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used the following command to concatenate everything into one big blob:
npx repomix --ignore ".github/,.parcel-cache/,dist/,docs/,node_modules/,TODO.md,yarn.lock,LISENCE,features/,.dockerignore,.gitignore"Then I pasted it into various LLMs with this prompt:
OpenAI O1: https://chatgpt.com/share/67a2f13f-eed4-8000-a7c5-2b3194a6bd42
Google Gemini: https://gist.github.com/erikdubbelboer/529ba1ab62e7c9603a84b454be595da9
DeepSeek R1: https://gist.github.com/erikdubbelboer/9487f4262a6aae9bcc3ae765b3e7d8b6
The prompt was too big for Claude 3.5 Sonnet.
Most "bugs" or issues it find are either wrong or irrelevant. For example any concurrency or security issue in testproxy. Some things are even wrong such as Gemini seeing a unicode character that isn't there.