Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: get int parsing from payload better #21

Merged
merged 1 commit into from
May 12, 2022
Merged

fix: get int parsing from payload better #21

merged 1 commit into from
May 12, 2022

Conversation

pablocampogo
Copy link
Contributor

@pablocampogo pablocampogo commented May 11, 2022 •
edited
Loading

  • Made int parsing from relay Response better (less unnecessary type conversions)
  • Added some tests for my changes :)
  • Also ran go mod tidy many not used dependencies got deleted

@pablocampogo pablocampogo requested a review from rem1niscence May 11, 2022 23:50
@pablocampogo pablocampogo self-assigned this May 11, 2022
@height
Copy link

height bot commented May 11, 2022

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@pablocampogo pablocampogo force-pushed the get-int-parsing-better-for-string branch from 283c52d to 9b5a1fa Compare May 11, 2022 23:51
rem1niscence
rem1niscence approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@rem1niscence rem1niscence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rem1niscence rem1niscence merged commit b146c0b into master May 12, 2022
@rem1niscence rem1niscence deleted the get-int-parsing-better-for-string branch May 12, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rem1niscence rem1niscence rem1niscence approved these changes

Assignees

@pablocampogo pablocampogo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pablocampogo @rem1niscence