Several cache fixes #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pablocampogo
suggested changes
May 26, 2022
| } | ||
|
|
||
| caches, err := cache.ConnectoCacheClients(ctx, conns, "", isRedisCluster) | ||
| caches, err := cache.ConnectoCacheClients(ctx, cacheConns, "", isRedisCluster) |
There was a problem hiding this comment.
Suggested change
| caches, err := cache.ConnectoCacheClients(ctx, cacheConns, "", isRedisCluster) | |
| caches, err := cache.ConnectToCacheClients(ctx, cacheConns, "", isRedisCluster) |
There was a problem hiding this comment.
This function was not added in this PR, can ignore the comment if it's too much work to change it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a number of fixes regarding cache and in minor effect store operations, on store, now if one store fails it wont stop the execution of the other stores, same for some cache operations. Also added some checks to not add invalid data to the stores