Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added unit tests for staked nodes and stakes apps pool addresses #1540

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Added unit tests for staked nodes and stakes apps pool addresses #1540

merged 2 commits into from
Apr 4, 2023

Conversation

Olshansk
Copy link
Member

@Olshansk Olshansk commented Apr 4, 2023

A test to verify an answer prompted by an investigation from PoktNews: https://twitter.com/PoktNews/status/1643368259339550721

@Olshansk Olshansk added the test unit test label Apr 4, 2023
@Olshansk Olshansk added this to the Network Quality of Life milestone Apr 4, 2023
@Olshansk Olshansk self-assigned this Apr 4, 2023
@cr-gpt
Copy link

cr-gpt bot commented Apr 4, 2023

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables for this repo. you could follow readme for more information

@reviewpad
Copy link

reviewpad bot commented Apr 4, 2023

AI-Generated Pull Request Summary: This pull request includes two patches:

  1. Added unit tests for staked nodes and stakes apps addresses: This patch adds new unit tests to verify the correct functionality of retrieving staked nodes pool address and app nodes pool address in the account keeper system.

  2. Updated comments: This patch adds a description for the TestGetPoolAddresses function, explaining the purpose of the pool addresses in the protocol and their role in managing staked pool funds.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Apr 4, 2023
@reviewpad
Copy link

reviewpad bot commented Apr 4, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@Olshansk Olshansk merged commit 5a55424 into staging Apr 4, 2023
@Olshansk Olshansk deleted the account_test branch April 4, 2023 22:41
@jessicadaugherty jessicadaugherty mentioned this pull request Apr 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessicadaugherty jessicadaugherty Awaiting requested review from jessicadaugherty

Assignees

@Olshansk Olshansk

Labels
small Pull request is small test unit test waiting-for-review
Projects
V0 Dashboard
Status: Done
Milestone
Network Quality of Life
Development

Successfully merging this pull request may close these issues.
1 participant
@Olshansk