Upgrade Go version to 1.21 #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The coming patch #1581 uses Go Generics that is available since Go 1.18. Since .github/workflows/Dockerfile pulls a container with Go 1.17, that patch breaks CI workflow. This patch upgrades Go version in all CI workflows to the latest version 1.21.
|
This is the fix for a failure at the step What's failing here is |
Olshansk
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The coming patch #1581 uses Go Generics that is available since Go 1.18. Since .github/workflows/Dockerfile pulls a container with Go 1.17, that patch breaks CI workflow. This patch upgrades Go version in all CI workflows to the latest version 1.21.
Description
Summary generated by Reviewpad on 21 Dec 23 08:47 UTC
This pull request upgrades the Go version in all CI workflows to version 1.21. The current version 1.18 is causing issues with the coming patch that uses Go Generics available since Go 1.18. The upgrade is done in the .circleci/config.yml file for the build, test, and trigger-pocket-core-deployments-branches sections. It is also done in the .github/workflows/Dockerfile file. Additionally, the go.mod and README.md files are updated to reflect the new Go version. The patch includes a total of 13 insertions and 10 deletions across 6 files.