[Utility] Local Proof of Stake CLI - CLI and RPC client [part 1/2] - Issue #112 #177

deblasis · 2022-08-25T15:32:58Z

Description

This PR updates the CLI so that it provides access to the Utility module commands via RPC calls

Issue

Part of Issue #112 but we decided to split the work in 2 separate PRs

Type of change

Please mark the options that are relevant.

New feature, functionality or library

List of changes

Updated CLI
Refactored the previous implementation of the "debug" utility into it's own subcommand

Testing

make test_all
LocalNet w/ all of the steps outlined in the README

Checklist

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have tested my changes using the available tooling
If applicable, I have made corresponding changes to related local or global README
If applicable, I have added new diagrams using mermaid.js
If applicable, I have added tests that prove my fix is effective or that my feature works

Signed-off-by: Alessandro De Blasis <alex@deblasis.net>

andrewnguyen22

Overall looks really good. Love Cobra - seems you took a lot from V0

I want a simple README in the CLI package laying out the CLI structure

We will also need user usage and specification documents - but that can be done in a separate issue (please open followup)

app/client/cli/actor.go

utility/types/message.go

app/client/cli/utils.go

…_proof_of_stake_cli_CLI Signed-off-by: Alessandro De Blasis <alex@deblasis.net>

Olshansk · 2022-10-27T20:29:13Z

@deblasis Please re-request the review when this is ready

deblasis · 2022-10-29T21:45:10Z

@deblasis Please re-request the review when this is ready

I think I need an answer from @andrewnguyen22 here: #177 (comment) but apart from that it's ready I believe.

Olshansk · 2022-11-01T00:52:40Z

@deblasis Please re-request the review when this is ready

I think I need an answer from @andrewnguyen22 here: #177 (comment) but apart from that it's ready I believe.

https://github.com/pokt-network/pocket/pull/177/files/27e36c2e94150e8cec43e9c5caa383b2d9940a60#r1009984269

Olshansk

Approving with a few minor comments, but otherwise approving because it's past the point of "good enough" and we'll iterate on main.

@deblasis I know we talked bout a Makefile or utility with examples of how to curl and such. Is that in a followup PR?

Olshansk · 2022-11-02T21:08:46Z

app/client/cli/account.go

+func accountCommands() []*cobra.Command {
+	cmds := []*cobra.Command{
+		{
+			Use:     "Send <fromAddr> <to> <amount>",


I'm excited for this :)

Olshansk · 2022-11-02T21:09:35Z

app/client/cli/account.go

+				if err != nil {
+					return err
+				}
+				// NOTE: since we don't have a keybase yet (tracked in #150), we are currently inferring the `fromAddr` from the PrivateKey supplied via the flag `--path_to_private_key_file`


Great comments.

CC @Jasonyou1995 for context

Olshansk · 2022-11-02T21:21:28Z

app/client/cli/actor.go

@@ -0,0 +1,315 @@
+package cli


Resolving this per the TODOs left alongside cobra.ExactArgs

utility/types/message.go

runtime/test_artifacts/generator.go

app/client/cli/doc/CHANGELOG.md

deblasis · 2022-11-02T21:54:10Z

@Olshansk :

Approving with a few minor comments, but otherwise approving because it's past the point of "good enough" and we'll iterate on main.

@deblasis I know we talked bout a Makefile or utility with examples of how to curl and such. Is that in a followup PR?

#169 (comment)

scroll down a bit, under "demo". Obviously that's just markdown that we can package the way we want. Just let me know how and I'll do it.

Co-authored-by: Daniel Olshansky <olshansky.daniel@gmail.com>

Olshansk · 2022-11-02T22:29:19Z

@deblasis Noted that the demo is there. Will review #169 after we merge in 1/2 and 2/2 to make the conflict resolution easier.

Signed-off-by: Alessandro De Blasis <alex@deblasis.net>

deblasis added 7 commits August 24, 2022 18:16

chore(P2P): discuss comment on redundant line

b0f2531

feat(CLI): scaffolding

78c8d7d

Signed-off-by: Alessandro De Blasis <alex@deblasis.net>

feat(CLI): scaffolding

32e3072

feat(CLI): scaffolding

4f791f0

feat(CLI): scaffolding

ee1003a

Signed-off-by: Alessandro De Blasis <alex@deblasis.net>

typo(P2P): redundant line

83ec894

fix(CLI): merge conflict fix

d7c8f5d

Olshansk assigned deblasis Aug 27, 2022

Olshansk added core Core infrastructure - protocol related persistence Persistence specific changes priority:high labels Aug 27, 2022

Olshansk added this to the M1: Pocket PoS (Proof of Stake) milestone Aug 27, 2022

Olshansk unassigned deblasis Aug 27, 2022

Olshansk added client work needed to interface with the node (rpc, cli, etc..) tooling tooling to support development, testing et al and removed persistence Persistence specific changes labels Aug 27, 2022

Olshansk assigned deblasis Aug 27, 2022

Olshansk requested review from Olshansk and andrewnguyen22 August 27, 2022 19:22

deblasis added 6 commits August 29, 2022 14:52

chore(go.mod): tidy + vendor

2bda3f3

feat(Utility): CLI RPC client function

bc6ad76

feat(Utility): RPC defaults const

e60ea54

feat(Utility): GetSignBytes

ec76e05

feat(Utility): CLI utils

6ae396e

feat(Utility): stake cmd scaffolding

b87b721

deblasis changed the title ~~[WIP] [Utility] Local Proof of Stake CLI - CLI and RPC client [part 1/2] - Issue #112~~ [Utility] Local Proof of Stake CLI - CLI and RPC client [part 1/2] - Issue #112 Aug 29, 2022

deblasis marked this pull request as ready for review August 29, 2022 15:05

deblasis requested a review from a team as a code owner August 29, 2022 15:05

deblasis mentioned this pull request Aug 29, 2022

[Utility] Local Proof of Stake CLI #112

Closed

16 tasks

andrewnguyen22 reviewed Aug 30, 2022

View reviewed changes

app/client/cli/actor.go Outdated Show resolved Hide resolved

app/client/cli/actor.go Outdated Show resolved Hide resolved

utility/types/message.go Outdated Show resolved Hide resolved

app/client/cli/utils.go Outdated Show resolved Hide resolved

deblasis added 8 commits October 24, 2022 11:29

chore(Utility): GetBytes -> GetCanonicalBytes

13485a2

chore(CLI): actorCmd -> accountCmd

ce28724

docs(CLI): fromAddr note (address currently sourced from pk)

e91a1ab

Merge remote-tracking branch 'upstream/main' into issue/utility_local…

476b124

…_proof_of_stake_cli_CLI Signed-off-by: Alessandro De Blasis <alex@deblasis.net>

chore(Runtime): new default value from main

3c0f0ba

refactor(CLI): moving utility functions in utils.go

c740614

chore(CLI): NewDebug -> NewDebugCommand

1a95835

docs(CLI): added todos for exactArgs

f75a872

deblasis requested review from andrewnguyen22 and Olshansk October 29, 2022 21:45

feat(RPC): /v1/consensus/round_state

4cfae32

deblasis added 3 commits November 1, 2022 01:08

refactor(CLI): Stake command

c9efa96

fix(CLI): tx message signing

20c3918

feat(CLI): reporting statuscode and body

b0a5a78

deblasis mentioned this pull request Nov 1, 2022

[Utility] Local Proof of Stake CLI - RPC server [part 2/2] - Issue #112 #176

Merged

9 tasks

Olshansk approved these changes Nov 2, 2022

View reviewed changes

deblasis and others added 3 commits November 2, 2022 21:54

Update utility/types/message.go

225be2f

Co-authored-by: Daniel Olshansky <olshansky.daniel@gmail.com>

chore(Runtime): comment spacing

5cecd49

docs(CLI): Changelog

7238b03

deblasis added 2 commits November 3, 2022 10:31

refactor(Consensus): mocks with Return(nil) and not Do(...)

d9743f5

Signed-off-by: Alessandro De Blasis <alex@deblasis.net>

chore(Consensus): SetBus mock Do(func(modules.Bus) {}) -> Return()

2ec2448

Signed-off-by: Alessandro De Blasis <alex@deblasis.net>

andrewnguyen22 approved these changes Nov 3, 2022

View reviewed changes

deblasis merged commit eee063c into pokt-network:main Nov 3, 2022

Olshansk mentioned this pull request Nov 3, 2022

[Keybase] Miniature Keybase Implementation to Enable M1 - Create and Delete #150

Closed

10 tasks

jessicadaugherty mentioned this pull request Mar 28, 2023

[Tooling] RPC specification parity #628

Closed

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Utility] Local Proof of Stake CLI - CLI and RPC client [part 1/2] - Issue #112 #177

[Utility] Local Proof of Stake CLI - CLI and RPC client [part 1/2] - Issue #112 #177

deblasis commented Aug 25, 2022 •

edited

Loading

andrewnguyen22 left a comment •

edited

Loading

Olshansk commented Oct 27, 2022

deblasis commented Oct 29, 2022

Olshansk commented Nov 1, 2022

Olshansk left a comment

Olshansk Nov 2, 2022

deblasis Nov 2, 2022

Olshansk Nov 2, 2022

Olshansk Nov 2, 2022

deblasis commented Nov 2, 2022 •

edited

Loading

Olshansk commented Nov 2, 2022

[Utility] Local Proof of Stake CLI - CLI and RPC client [part 1/2] - Issue #112 #177

[Utility] Local Proof of Stake CLI - CLI and RPC client [part 1/2] - Issue #112 #177

Conversation

deblasis commented Aug 25, 2022 • edited Loading

Description

Issue

Type of change

List of changes

Testing

Checklist

andrewnguyen22 left a comment • edited Loading

Choose a reason for hiding this comment

Olshansk commented Oct 27, 2022

deblasis commented Oct 29, 2022

Olshansk commented Nov 1, 2022

Olshansk left a comment

Choose a reason for hiding this comment

Olshansk Nov 2, 2022

Choose a reason for hiding this comment

deblasis Nov 2, 2022

Choose a reason for hiding this comment

Olshansk Nov 2, 2022

Choose a reason for hiding this comment

Olshansk Nov 2, 2022

Choose a reason for hiding this comment

deblasis commented Nov 2, 2022 • edited Loading

Olshansk commented Nov 2, 2022

deblasis commented Aug 25, 2022 •

edited

Loading

andrewnguyen22 left a comment •

edited

Loading

deblasis commented Nov 2, 2022 •

edited

Loading