Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infrastructure] LocalNet on Kubernetes #354
[Infrastructure] LocalNet on Kubernetes #354
Changes from 47 commits
f7a82ba
62683a5
67132eb
764c722
c2c0fd5
2960669
1455a40
ca9ebeb
1fd8bb1
048947c
2fb9f04
e66bd74
cc95782
5198b1d
f0aa697
8b50310
52a44d7
846ba6c
558768e
03f3ba3
5b824af
d53eded
5225c3e
b2cb5af
80d790d
c94cb4f
78f09da
372bb6c
b92bc03
1b103d7
0f354d9
7631fd3
1d57ceb
ac40457
06c8ef3
cba72f7
a778f2c
2e47e2c
fa24420
ebd5dd8
defca3b
03e5a04
36b1e5f
19d6ba4
fae2775
28c2ee0
27d0daf
294ae17
bc846f3
792f973
25a4a36
cc96bf3
8364117
1261079
f75fde2
b46d2d3
7188a2e
1bf5fd4
54a7629
7ec2217
33a45cf
469e67a
a8df9d9
5a5c042
62561c6
46d3f74
2135d26
fe98bce
1e59e9c
1c17e68
f3d083b
8e864f3
93851be
3347fbe
b8ba1c9
5a1325b
da4a402
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On my machine (Windows with Ubuntu 20.04 running in WSL2)
this command fails with
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I guess that
helm
CLI binary is a requirement that should be considered in theinstall_cli_deps
as wellThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh no, I was sure tilt install script can be executed on Linux because the same script is offered for both macOS and Linux. https://docs.tilt.dev/install.html
Looking at the script, even on Linux, they check if
brew
CLI is available. That is probably because Homebrew supports Linux. Whenbrew
cli is available, they try to installtilt
with it. Do you usebrew
a lot on your Linux WSL2 set up? It is possible your localbrew
set up might be out of date, have you tried to run the commands mentioned to fix this?It would be easier to install
tilt
withgo install
like we do with other binaries, but unfortunately this is not supported.Thanks for mentioning this, I added a helm install script to that make target. 🫡
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which node does this shell into?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With
localnet_shell
you get into a pod withpocket
andclient
CLI available. Both binaries are automatically updated when code is changed in the repo. How do I make this more obvious – document it in .md files and make target?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize you left this comment and it's in the code, but developers would be confused. Please add a section in
localnet/README
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of listing the directories in readme I am going to provide a link to the Tiltfile to that line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we delete this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would keep it in case developer wants to connect to the postgres cluster with their own tooling (dbeaver, etc.) - that requires exposing a port. I changed the comment to reflect this is an example. Do you think this makes sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, just need to update the comment.