[Infra] KISS 3 - Cluster Manager [Merge me after #521] - (Issues: #490) #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Daniel Olshansky <olshansky@pokt.network>
Co-authored-by: Daniel Olshansky <olshansky@pokt.network>
Co-authored-by: Daniel Olshansky <olshansky@pokt.network>
Co-authored-by: Daniel Olshansky <olshansky@pokt.network>
Co-authored-by: Daniel Olshansky <olshansky@pokt.network>
This reverts commit facca64.
…-network/pocket into issue/416-kiss-peer-discovery-light
…-discovery-light Signed-off-by: Alessandro De Blasis <alex@deblasis.net>
…ster-manager Signed-off-by: Alessandro De Blasis <alex@deblasis.net>
16 tasks
Olshansk
approved these changes
Feb 17, 2023
| @@ -3,3 +3,9 @@ kind: ServiceAccount | |||
| metadata: | |||
| name: debug-client-account | |||
| namespace: default | |||
| --- | |||
| apiVersion: v1 | |||
There was a problem hiding this comment.
NIT: You use v1 in some places and the full rbac.authorization.k8s.io/v1 in others.
I realize they both point to the stable version but figured we could be consistent.
There was a problem hiding this comment.
It doesn't work. One of the quirks of K8S I guess, cc: @okdas (TL;DR: it seems that Role and RoleBinding don't like apiVersion: v1)
I was getting kubernetes apply: error mapping /Role: no matches for kind "Role" in version "v1"
I stole the examples from here https://kubernetes.io/docs/reference/access-authn-authz/rbac/
Co-authored-by: Daniel Olshansky <olshansky@pokt.network>
…ocket into issue/490-cluster-manager
Co-authored-by: Daniel Olshansky <olshansky@pokt.network>
…ocket into issue/490-cluster-manager
12 tasks
bryanchriswhite
added a commit
that referenced
this pull request
Feb 20, 2023
* pokt/main: [Infra] KISS 3 - Cluster Manager [Merge me after #521] - (Issues: #490) (#522) Refactor/fix state sync logs (#515) [P2P] KISS 2 - Peer discovery [Merge me after #520] - (Issues: #416, #429) (#521) [Core] KISS 1 - Finite State Machine [Merge me first] - (Issue: #499) (#520) [CLI] Stake command bugfix (#518) [CLI] Cannot run make localnet_client_debug: Cannot initialise the keybase with the validator keys: Unable to find YAML file (#517) Fix the link shown by `make go_doc` Fixed duplicate GITHUB_WIKI tag [Documentation] Update Devlog Formatting (#512) [Docs & Bugs] Minor fixes post keybase changes (#513) [Utility] Foundational bugs, tests, code cleanup and improvements (1 / 2) (#503) [Tooling] Integrate Keybase w/ CLI (Issue #484 ) (#501) update devlog2.md update devlog2.md Update devlog1.md
bryanchriswhite
added a commit
that referenced
this pull request
Feb 20, 2023
* pokt/main: [Infra] KISS 3 - Cluster Manager [Merge me after #521] - (Issues: #490) (#522) Refactor/fix state sync logs (#515) [P2P] KISS 2 - Peer discovery [Merge me after #520] - (Issues: #416, #429) (#521) [Core] KISS 1 - Finite State Machine [Merge me first] - (Issue: #499) (#520) [CLI] Stake command bugfix (#518) [CLI] Cannot run make localnet_client_debug: Cannot initialise the keybase with the validator keys: Unable to find YAML file (#517) Fix the link shown by `make go_doc` Fixed duplicate GITHUB_WIKI tag [Documentation] Update Devlog Formatting (#512) [Docs & Bugs] Minor fixes post keybase changes (#513) [Utility] Foundational bugs, tests, code cleanup and improvements (1 / 2) (#503) [Tooling] Integrate Keybase w/ CLI (Issue #484 ) (#501) update devlog2.md update devlog2.md Update devlog1.md
deblasis
added a commit
that referenced
this pull request
Feb 20, 2023
…ue: #498) (#523) ## Description This PR has been extracted from #491 and is, hopefully, more digestible from a code-review and scope point of view. This simply adds entrypoints and basic logic for node bootstrapping leveraging the finite state machine ## Issue Fixes #498 ## Type of change Please mark the relevant option(s): - [x] New feature, functionality or library - [ ] Bug fix - [ ] Code health or cleanup - [ ] Major breaking change - [ ] Documentation - [ ] Other <!-- add details here if it a different type of change --> ## List of changes - Ability to fetch an addressbook from a bootstrap node(s) (by convention the first validator in LocalNet) - It's possible to override bootstrap nodes via CLI flag ## Testing - [x] `make develop_test` - [x] [LocalNet](https://github.com/pokt-network/pocket/blob/main/docs/development/README.md) w/ all of the steps outlined in the `README` ## Required Checklist - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have tested my changes using the available tooling - [x] I have updated the corresponding CHANGELOG ### If Applicable Checklist - [ ] I have updated the corresponding README(s); local and/or global - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added, or updated, [mermaid.js](https://mermaid-js.github.io) diagrams in the corresponding README(s) - [ ] I have added, or updated, documentation and [mermaid.js](https://mermaid-js.github.io) diagrams in `shared/docs/*` if I updated `shared/*`README(s) --------- Signed-off-by: Alessandro De Blasis <alex@deblasis.net> Co-authored-by: Dmitry K <okdas@pm.me> Co-authored-by: Dmitry Knyazev <okdas@users.noreply.github.com> Co-authored-by: Daniel Olshansky <olshansky@pokt.network> Co-authored-by: Daniel Olshansky <olshansky.daniel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR has been extracted from #491 and is, hopefully, more digestible from a code-review and scope point of view.
Issue
Fixes #490
Type of change
Please mark the relevant option(s):
List of changes
Testing
make develop_testREADMERequired Checklist
If Applicable Checklist
shared/docs/*if I updatedshared/*README(s)