Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Libp2p] Plug it in (part 5) #546

Merged
merged 2 commits into from
Mar 3, 2023
Merged

[Libp2p] Plug it in (part 5) #546

merged 2 commits into from
Mar 3, 2023

Conversation

bryanchriswhite
Copy link
Contributor

@bryanchriswhite bryanchriswhite commented Feb 24, 2023

Description

This is another (last, probably) in a series of PRs split out from #500. Here we finally enable support for use of the new libp2p module (and dependent packages) by considering the config changes made in #535 in the node and debug CLI.

Issue

#347

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Major breaking change
  • Documentation
  • Other

List of changes

  • Support libp2p module in node
  • Support libp2p module in debug CLI

Testing

  • make develop_test
  • LocalNet w/ all of the steps outlined in the README

Required Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have tested my changes using the available tooling
  • I have updated the corresponding CHANGELOG

If Applicable Checklist

  • I have updated the corresponding README(s); local and/or global
  • I have added tests that prove my fix is effective or that my feature works
  • I have added, or updated, mermaid.js diagrams in the corresponding README(s)
  • I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@bryanchriswhite bryanchriswhite added the p2p P2P specific changes label Feb 24, 2023
@bryanchriswhite bryanchriswhite self-assigned this Feb 24, 2023
@bryanchriswhite bryanchriswhite marked this pull request as ready for review February 24, 2023 11:49
@bryanchriswhite
Copy link
Contributor Author

bryanchriswhite commented Feb 27, 2023

This PR is based off of the chore/libp2p-3 branch but is also dependent on the chore/config branch. As a result tests and linting will fail until #535 is merged.

Comment on lines 7 to +11
"github.com/manifoldco/promptui"
"github.com/spf13/cobra"
"google.golang.org/protobuf/types/known/anypb"

"github.com/pokt-network/pocket/libp2p"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not actionable: 💯 I like this. I guess we should start doing this across the board and separate external/internal imports. Maybe we should create an issue to tackle it in one scoop also to create team awareness since it's gonna be discussed at least once in standup at some point.

Probably too boring to be outsourced to the community 🤔 and however low priority, something to do to kill boredom with more... boredom 😆. Wdyt?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have summoned the community in #185

Copy link
Contributor

@deblasis deblasis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚂🚃🚃🚃🚃🚃

@bryanchriswhite bryanchriswhite linked an issue Mar 1, 2023 that may be closed by this pull request
6 tasks
@bryanchriswhite bryanchriswhite changed the base branch from chore/libp2p-3 to main March 3, 2023 12:55
@bryanchriswhite bryanchriswhite merged commit ed83458 into main Mar 3, 2023
@bryanchriswhite bryanchriswhite deleted the chore/libp2p-4 branch March 3, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2p P2P specific changes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[P2P] Integrate LibP2P
3 participants