[DevNet] tweaks for remote environments #601

okdas · 2023-03-21T23:44:05Z

Description

Some tweaks necessary to run DevNet.

Issue

#307

Type of change

Please mark the relevant option(s):

Documentation
Tooling

List of changes

Add cluster-manager to the container image
Add changes to the documentation

Testing

verify validators work on DevNet
make develop_test
LocalNet w/ all of the steps outlined in the README

Required Checklist

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
I have tested my changes using the available tooling
I have updated the corresponding CHANGELOG

If Applicable Checklist

I have updated the corresponding README(s); local and/or global
I have added tests that prove my fix is effective or that my feature works
I have added, or updated, mermaid.js diagrams in the corresponding README(s)
I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

github-actions

The changelog validation failed with the following output:

"Missing changelog in module: build/

Changelog verification failed. See error messages for more detail.
"

Please update the relevant CHANGELOG.md files and ensure they follow the correct format.

github-actions

The changelog validation failed with the following output:

"Missing changelog in module: build/

Changelog verification failed. See error messages for more detail.
"

Please update the relevant CHANGELOG.md files and ensure they follow the correct format.

github-actions

The changelog validation failed with the following output:

"Latest date in libp2p/docs/CHANGELOG.md is incorrect.
Latest: 2023-03-23, Current: 2023-03-24

Changelog verification failed. See error messages for more detail.
"

Please update the relevant CHANGELOG.md files and ensure they follow the correct format.

github-actions

The changelog validation failed with the following output:

Missing changelog in module: build/

Changelog verification failed. See error messages for more detail.

Please update the relevant CHANGELOG.md files and ensure they follow the correct format.

The check succeeded, dismissing the review comment.

docs/development/README.md

docs/releases/README.md

build/Dockerfile.debian.dev

build/localnet/README.md

dylanlott

LGTM! 🔎

dylanlott · 2023-04-03T23:57:09Z

.github/workflows/main.yml

@@ -99,7 +99,7 @@ jobs:
    runs-on: ubuntu-latest
    needs: test-multiple-go-versions
    # Until we have developer environments, we don't need the images built on other that main branches.
-    if: github.ref == 'refs/heads/main'
+    if: github.ref == 'refs/heads/main' || contains(github.event.pull_request.labels.*.name, 'push-image')


dylanlott · 2023-04-04T00:08:46Z

docs/releases/README.md


-Code built from commits in Pull Requests, is tagged as `pr-<number>`, as well as `sha-<7 digit sha>`.
+Code built from commits in Pull Requests, is tagged as `pr-<number>`, as well as `sha-<7 digit sha>`. You can optionally build an image from a Pull Request by attaching a `push-image` label to the pull request to force CI to upload a container image from a non-main branch.


Should protocol-infra docs reference this convention?

@dylanlott Haha, they do: https://github.com/pokt-network/protocol-infra#how-to-run-a-pocket-version-from-the-developers-branch

@dylanlott

@dylanlott performed a second round of reviews

* pokt/main: [Utility][RPC][CLI] Querying governance parameters (Issue #619) (#622) [Persistence][Utility] Separate all CreateAndApply functions into more functional components - Issue #508 (#652) [Persistence][Utility] Pools Address hack removal + state accessor fix for params and flags (#654) [PERSISTENCE] SavePoints and Rollbacks design document (Issue #493) (#533) Update reviewpad.yml Added ChatGPT-CodeReview workflow (#649) Update reviewpad.yml Added default reviewpad.yml file (#648) [DevNet] tweaks for remote environments (#601) [Documentation] Swap validator and non-validator triggers when finished synching (#646) [Consensus] Configuration entry point state sync (#528)

…p-modules * pokt/main: [Utility][RPC][CLI] Querying governance parameters (Issue pokt-network#619) (pokt-network#622) [Persistence][Utility] Separate all CreateAndApply functions into more functional components - Issue pokt-network#508 (pokt-network#652) [Persistence][Utility] Pools Address hack removal + state accessor fix for params and flags (pokt-network#654) [PERSISTENCE] SavePoints and Rollbacks design document (Issue pokt-network#493) (pokt-network#533) Update reviewpad.yml Added ChatGPT-CodeReview workflow (pokt-network#649) Update reviewpad.yml Added default reviewpad.yml file (pokt-network#648) [DevNet] tweaks for remote environments (pokt-network#601) [Documentation] Swap validator and non-validator triggers when finished synching (pokt-network#646) [Consensus] Configuration entry point state sync (pokt-network#528)

…p-modules * pokt/main: update pocket repo read.me (#667) Update reviewpad.yml [KEYBASE] Add improve comment on keybase config (#665) [E2E] Chore: Doc updates (#663) [E2E] Adds staking, unstaking, and sending tests (#653) [Utility][RPC][CLI] Querying governance parameters (Issue #619) (#622) [Persistence][Utility] Separate all CreateAndApply functions into more functional components - Issue #508 (#652) [Persistence][Utility] Pools Address hack removal + state accessor fix for params and flags (#654) [PERSISTENCE] SavePoints and Rollbacks design document (Issue #493) (#533) Update reviewpad.yml Added ChatGPT-CodeReview workflow (#649) Update reviewpad.yml Added default reviewpad.yml file (#648) [DevNet] tweaks for remote environments (#601) [Documentation] Swap validator and non-validator triggers when finished synching (#646) [Consensus] Configuration entry point state sync (#528)

okdas added 2 commits March 21, 2023 16:38

build debug client for dev image

814fb80

also produce cluster manager

947aaaf

okdas self-assigned this Mar 21, 2023

okdas added the infra Core infrastructure - not protocol related label Mar 21, 2023

github-actions bot previously requested changes Mar 21, 2023

View reviewed changes

okdas added the push-image Build and push a container image on non-main builds label Mar 22, 2023

label to push image

37d358c

github-actions bot previously requested changes Mar 22, 2023

View reviewed changes

update localnet docs

9b90f18

github-actions bot previously requested changes Mar 24, 2023

View reviewed changes

--wip-- [skip ci]

2a7d2c7

okdas mentioned this pull request Mar 28, 2023

[Documentation] New environment documentation improvements #624

Merged

17 tasks

Merge branch 'main' into okdas/devnet-tweaks

9150839

github-actions bot previously requested changes Mar 28, 2023

View reviewed changes

okdas added 2 commits March 28, 2023 14:40

add docs clarifications

9f6a45d

add changelog

baff4df

clarify changelog

7c11524

okdas added this to the M2: Pocket DoS (Devnet of Servicers) milestone Mar 28, 2023

okdas marked this pull request as ready for review March 28, 2023 21:50

okdas requested a review from Olshansk March 29, 2023 17:48

Olshansk previously requested changes Mar 29, 2023

View reviewed changes

okdas and others added 2 commits March 31, 2023 15:16

resolve req changes

ce9d5bd

Merge branch 'main' into okdas/devnet-tweaks

11d671f

okdas requested a review from Olshansk March 31, 2023 23:01

jessicadaugherty requested a review from dylanlott April 3, 2023 19:23

dylanlott approved these changes Apr 4, 2023

View reviewed changes

okdas merged commit 01d7655 into main Apr 4, 2023

okdas deleted the okdas/devnet-tweaks branch April 4, 2023 00:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DevNet] tweaks for remote environments #601

[DevNet] tweaks for remote environments #601

okdas commented Mar 21, 2023 •

edited

Loading

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

dylanlott left a comment

dylanlott Apr 3, 2023

dylanlott Apr 4, 2023

okdas Apr 4, 2023


		Code built from commits in Pull Requests, is tagged as `pr-<number>`, as well as `sha-<7 digit sha>`.
		Code built from commits in Pull Requests, is tagged as `pr-<number>`, as well as `sha-<7 digit sha>`. You can optionally build an image from a Pull Request by attaching a `push-image` label to the pull request to force CI to upload a container image from a non-main branch.

[DevNet] tweaks for remote environments #601

[DevNet] tweaks for remote environments #601

Conversation

okdas commented Mar 21, 2023 • edited Loading

Description

Issue

Type of change

List of changes

Testing

Required Checklist

If Applicable Checklist

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

dylanlott left a comment

Choose a reason for hiding this comment

dylanlott Apr 3, 2023

Choose a reason for hiding this comment

dylanlott Apr 4, 2023

Choose a reason for hiding this comment

okdas Apr 4, 2023

Choose a reason for hiding this comment

okdas commented Mar 21, 2023 •

edited

Loading