Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CONSENSUS] bugfix for: unable to send txs in localnet - Issue #631 #632

Merged
merged 2 commits into from
Mar 29, 2023
Merged

[CONSENSUS] bugfix for: unable to send txs in localnet - Issue #631 #632

merged 2 commits into from
Mar 29, 2023

Conversation

deblasis
Copy link
Contributor

Description

This PR addresses the bug reported in #631

Issue

Fixes #631

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Major breaking change
  • Documentation
  • Other

List of changes

  • The apply logic was running indiscriminately and it has to run only if the leader is not preparing a new block

Testing

  • make develop_test; if any code changes were made
  • Docker Compose LocalNet; if any major functionality was changed or introduced
  • k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
  • I have tested my changes using the available tooling
  • I have updated the corresponding CHANGELOG

If Applicable Checklist

  • I have updated the corresponding README(s); local and/or global
  • I have added tests that prove my fix is effective or that my feature works
  • I have added, or updated, mermaid.js diagrams in the corresponding README(s)
  • I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@deblasis deblasis added bug Something isn't working - expected behaviour is incorrect consensus Consensus specific changes labels Mar 29, 2023
@deblasis deblasis self-assigned this Mar 29, 2023
github-actions[bot]
github-actions bot previously requested changes Mar 29, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog validation failed with the following output: 
Missing changelog in module: consensus/

Changelog verification failed. See error messages for more detail.

Please update the relevant CHANGELOG.md files and ensure they follow the correct format.

@deblasis deblasis requested a review from 0xBigBoss March 29, 2023 07:31
@github-actions github-actions bot dismissed their stale review March 29, 2023 07:31

The check succeeded, dismissing the review comment.

@deblasis deblasis marked this pull request as ready for review March 29, 2023 07:31
@deblasis deblasis mentioned this pull request Mar 29, 2023
Closed
10 tasks
@deblasis deblasis merged commit 385cef4 into main Mar 29, 2023
bryanchriswhite added a commit that referenced this pull request Mar 31, 2023
@bryanchriswhite
Merge remote-tracking branch 'pokt/main' into HEAD
c09aa70 
* pokt/main:
  [Infra] cluster-manager should not stake validators that are already staked in genesis at startup - Issue #635 (#640)
  [Core] Persistence connection pooling and write context management (#627)
  [Core] Improve module creation documentation - Issue #509 (#623)
  [Tooling][Bug] Fix: changelog verifiers fails to dismiss the review - Issue #638 (#639)
  [CONSENSUS] bugfix for: unable to send txs in localnet - Issue #631 (#632)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Olshansk Olshansk Olshansk approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

@0xBigBoss 0xBigBoss Awaiting requested review from 0xBigBoss

Assignees

@deblasis deblasis

Labels
bug Something isn't working - expected behaviour is incorrect consensus Consensus specific changes
Projects
V1 Dashboard
Status: Done
Milestone
M1: Pocket PoS (Proof of Stake)
Development

Successfully merging this pull request may close these issues.

[CONSENSUS] unable to send txs in localnet
2 participants
@deblasis @Olshansk