Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Validator cheatsheet and walkthrough #1012

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

okdas
Copy link
Member

@okdas okdas commented Dec 16, 2024

Summary

Adds documentation pages on how to skate the validator.

Type of change

Select one or more from the following:

Testing

  • Documentation: make docusaurus_start; only needed if you make doc changes
  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@okdas okdas added the documentation Improvements or additions to documentation label Dec 16, 2024
@okdas okdas added this to the Shannon Beta TestNet Support milestone Dec 16, 2024
@okdas okdas requested a review from Olshansk December 16, 2024 22:55
@okdas okdas self-assigned this Dec 16, 2024
@okdas okdas marked this pull request as ready for review December 16, 2024 22:55
Copy link
Member

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@okdas I reviewed the cheatsheet but not the walkthrough (haven't done the steps myself yet).

Can you please do the following:

  1. Review m changes in the cheatsheet (validate, update, etc...)
  2. Make the corresponding change sin the walkthrough

I'll do a round 2 later this week.

Copy link
Member Author

@okdas okdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will add your changes to the walkthrough as well.

{
"@type": "/cosmos.crypto.ed25519.PubKey",
"key": "YdlQyhjtrq9pk7afmz6oQ275L4FElzjzEJvB1fj3e1w="
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI - the output is actually a minimized version.


- **Check validator's commission and rewards**:
### How do I check my validator's commission and rewards?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you feel if we remove this completely? I don't believe we mint tokens for validators. Here are mint module params:

        inflation_rate_change: "0.0"
        inflation_max: "0.0"
        inflation_min: "0.0"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, let's remove it

@okdas
Copy link
Member Author

okdas commented Dec 20, 2024

Make the corresponding change sin the walkthrough

Ported the changes you did to the walkthrough as well 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

2 participants